You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2026/03/04 04:22:55 UTC
[PR] [SPARK-55782][UI] Replace CSS float right with Bootstrap 5 float-end utility [spark]
yaooqinn opened a new pull request, #54615:
URL: https://github.com/apache/spark/pull/54615
### What changes were proposed in this pull request?
Replaces 2 `float: right` CSS declarations in `webui.css` with Bootstrap 5 `float-end` utility class on the corresponding HTML elements.
**CSS changes:**
- `a.link`: removed `float: right`
- `span.expand-details`: removed `float: right`
**Scala changes (4 files, 6 elements):**
- `MasterPage.scala`: 2 link anchors added `float-end`
- `AllJobsPage.scala`: 1 link anchor added `float-end`
- `StageTable.scala`: 1 link anchor + 1 expand-details span added `float-end`
- `UIUtils.scala`: 1 expand-details span added `float-end`
### Why are the changes needed?
Aligns with Bootstrap 5 conventions — using utility classes instead of custom CSS for layout. Part of SPARK-55760 (Spark Web UI Modernization).
### Does this PR introduce _any_ user-facing change?
No. Visual appearance is identical.
### How was this patch tested?
Compilation verified. `float-end` produces the same `float: right !important` behavior as the removed CSS rules.
### Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with GitHub Copilot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55782][UI] Replace CSS float right with Bootstrap 5 float-end utility [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #54615: [SPARK-55782][UI] Replace CSS float right with Bootstrap 5 float-end utility
URL: https://github.com/apache/spark/pull/54615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55782][UI] Replace CSS float right with Bootstrap 5 float-end utility [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #54615:
URL: https://github.com/apache/spark/pull/54615#issuecomment-3998625329
Merged to master, thank you for the help @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org