[GitHub] [storm] HeartSaVioR commented on a change in pull request #2961: STORM-3344 prevent blacklist scheduler runtime exeception removing fr…

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #2961: STORM-3344 prevent blacklist scheduler runtime exeception removing fr…
URL: https://github.com/apache/storm/pull/2961#discussion_r264459074
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
 ##########
 @@ -155,8 +155,10 @@ private void badSupervisors(Map<String, SupervisorDetails> supervisors) {
 
         Set<Integer> newPorts = Sets.difference(supervisorPorts, cachedSupervisorPorts);
         if (newPorts.size() > 0) {
-            //add new ports to cached supervisor
-            cachedSupervisors.put(supervisorKey, Sets.union(newPorts, cachedSupervisorPorts));
+            //add new ports to cached supervisor.  We need a modifiable set to allow removing ports later.
 
 Review comment:
   nit: space between `/` and `a` - just for consistency

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services