You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/09 14:22:49 UTC
[GitHub] [iotdb] RYH61 opened a new pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
RYH61 opened a new pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191
IoTDB> create aligned timeseries root.sg1.d1(s1 INT32 tags(tag1=v1, tag2=v2) attributes(attr1=v1, attr2=v2), s2 DOUBLE tags(tag3=v3, tag4=v4) attributes(attr3=v3, attr4=v4))
IoTDB> show timeseries
+--------------+-----+-------------+--------+--------+-----------+-------------------------+---------------------------+
| timeseries|alias|storage group|dataType|encoding|compression| tags| attributes|
+--------------+-----+-------------+--------+--------+-----------+-------------------------+---------------------------+
|root.sg1.d1.s1| null| root.sg1| INT32| RLE| SNAPPY|{"tag1":"v1","tag2":"v2"}|{"attr2":"v2","attr1":"v1"}|
|root.sg1.d1.s2| null| root.sg1| DOUBLE| GORILLA| SNAPPY|{"tag4":"v4","tag3":"v3"}|{"attr4":"v4","attr3":"v3"}|
+--------------+-----+-------------+--------+--------+-----------+-------------------------+---------------------------+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk removed a comment on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
MarcosZyk removed a comment on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1068764126
Please add some IT/UT. Thanks for contribution. We decide to release this feature in v0.13 after complete this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r825649905
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -1762,7 +1762,9 @@ public TSStatus createAlignedTimeseries(TSCreateAlignedTimeseriesReq req) {
dataTypes,
encodings,
compressors,
- req.measurementAlias);
+ req.measurementAlias,
+ req.tagsList,
+ req.attributesList);
Review comment:
Please consider the compatibility with the interface of old version. Maybe add a new interface to support tag/attribute is a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r825649905
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -1762,7 +1762,9 @@ public TSStatus createAlignedTimeseries(TSCreateAlignedTimeseriesReq req) {
dataTypes,
encodings,
compressors,
- req.measurementAlias);
+ req.measurementAlias,
+ req.tagsList,
+ req.attributesList);
Review comment:
Please consider the compatibility with the interface of old version. May add a new interface to support tag/attribute is a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1063039776
[](https://coveralls.io/builds/47375521)
Coverage decreased (-2.3%) to 65.575% when pulling **c34cb8c395fa10351657cd483ec6632e660d48ee on RYH61:renyuhua** into **064010cbc2d770aa97aa564e4a22c4c81a31b0cc on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r827559018
##########
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##########
@@ -506,11 +506,20 @@ public void createAlignedTimeseries(
List<TSDataType> dataTypes,
List<TSEncoding> encodings,
List<CompressionType> compressors,
- List<String> measurementAliasList)
+ List<String> measurementAliasList,
+ List<Map<String, String>> tagsList,
+ List<Map<String, String>> attributesList)
Review comment:
Add don't forget update the doc of API.
https://github.com/apache/iotdb/blob/2f784502e52e15548babb2e4b9133f0a0731ba44/docs/UserGuide/API/Programming-Java-Native-API.md?plain=1#L150-L157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1068739930
If this feature is not released in v0.13.0, please take care of the compatibility of createAlignedTimeaeriesPlan in mlog of old versions. There's no tagOffset, tag or attribute in that, which means we may check whether the buffer has remaining when deserialize the plan of old versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] RYH61 commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
RYH61 commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r827613369
##########
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##########
@@ -506,11 +506,20 @@ public void createAlignedTimeseries(
List<TSDataType> dataTypes,
List<TSEncoding> encodings,
List<CompressionType> compressors,
- List<String> measurementAliasList)
+ List<String> measurementAliasList,
+ List<Map<String, String>> tagsList,
+ List<Map<String, String>> attributesList)
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r827559018
##########
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##########
@@ -506,11 +506,20 @@ public void createAlignedTimeseries(
List<TSDataType> dataTypes,
List<TSEncoding> encodings,
List<CompressionType> compressors,
- List<String> measurementAliasList)
+ List<String> measurementAliasList,
+ List<Map<String, String>> tagsList,
+ List<Map<String, String>> attributesList)
Review comment:
And don't forget update the doc of API.
https://github.com/apache/iotdb/blob/2f784502e52e15548babb2e4b9133f0a0731ba44/docs/UserGuide/API/Programming-Java-Native-API.md?plain=1#L150-L157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r827558000
##########
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##########
@@ -506,11 +506,20 @@ public void createAlignedTimeseries(
List<TSDataType> dataTypes,
List<TSEncoding> encodings,
List<CompressionType> compressors,
- List<String> measurementAliasList)
+ List<String> measurementAliasList,
+ List<Map<String, String>> tagsList,
+ List<Map<String, String>> attributesList)
Review comment:
IMO, adding a new interface rather than changing the old one is better for compatibility...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1063039776
[](https://coveralls.io/builds/47205727)
Coverage increased (+0.02%) to 67.893% when pulling **427384d9c89afc94bf5439c84b71f04053f4f94f on RYH61:renyuhua** into **064010cbc2d770aa97aa564e4a22c4c81a31b0cc on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r825660094
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -1762,7 +1762,9 @@ public TSStatus createAlignedTimeseries(TSCreateAlignedTimeseriesReq req) {
dataTypes,
encodings,
compressors,
- req.measurementAlias);
+ req.measurementAlias,
+ req.tagsList,
+ req.attributesList);
Review comment:
Hi, `tagsList` and `attributesList` are Optional in rpc.thrift...
Is there any compatibility problem about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r827556478
##########
File path: docs/zh/UserGuide/Operate-Metadata/Timeseries.md
##########
@@ -304,3 +304,35 @@ It costs 0.004s
```
> 注意,现在我们只支持一个查询条件,要么是等值条件查询,要么是包含条件查询。当然 where 子句中涉及的必须是标签值,而不能是属性值。
+
+创建对齐时间序列
+
+```
+create aligned timeseries root.sg1.d1(s1 INT32 tags(tag1=v1, tag2=v2) attributes(attr1=v1, attr2=v2), s2 DOUBLE tags(tag3=v3, tag4=v4) attributes(attr3=v3, attr4=v4))
Review comment:
Hi, you can modify this part of the doc.
https://github.com/apache/iotdb/blob/2f784502e52e15548babb2e4b9133f0a0731ba44/docs/zh/UserGuide/Operate-Metadata/Timeseries.md?plain=1#L56-L66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] RYH61 commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
RYH61 commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r827613148
##########
File path: docs/zh/UserGuide/Operate-Metadata/Timeseries.md
##########
@@ -304,3 +304,35 @@ It costs 0.004s
```
> 注意,现在我们只支持一个查询条件,要么是等值条件查询,要么是包含条件查询。当然 where 子句中涉及的必须是标签值,而不能是属性值。
+
+创建对齐时间序列
+
+```
+create aligned timeseries root.sg1.d1(s1 INT32 tags(tag1=v1, tag2=v2) attributes(attr1=v1, attr2=v2), s2 DOUBLE tags(tag3=v3, tag4=v4) attributes(attr3=v3, attr4=v4))
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1066403788
@MarcosZyk Can you please take a look if you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1066741528
Hi, consider updating the API? Java, python, c++…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou edited a comment on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
HTHou edited a comment on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1066741528
Hi, consider updating the API? Java, python, c++…
Also, don’t forget update the user guide for new feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk removed a comment on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
MarcosZyk removed a comment on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1068739930
If this feature is not released in v0.13.0, please take care of the compatibility of createAlignedTimeseriesPlan in mlog of old versions. There's no tagOffset, tag or attribute in that, which means we may check whether the buffer has remaining when deserialize the plan of old versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1068764126
Please add some IT/UT. Thanks for contribution. We decide to release this feature in v0.13 after complete this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on a change in pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on a change in pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#discussion_r825750189
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -1762,7 +1762,9 @@ public TSStatus createAlignedTimeseries(TSCreateAlignedTimeseriesReq req) {
dataTypes,
encodings,
compressors,
- req.measurementAlias);
+ req.measurementAlias,
+ req.tagsList,
+ req.attributesList);
Review comment:
If so, it will be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1063039776
[](https://coveralls.io/builds/47225512)
Coverage decreased (-0.002%) to 67.87% when pulling **00fc081076a77ef169754ad77c5c6b9d64b8ca58 on RYH61:renyuhua** into **064010cbc2d770aa97aa564e4a22c4c81a31b0cc on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk edited a comment on pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
MarcosZyk edited a comment on pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191#issuecomment-1068739930
If this feature is not released in v0.13.0, please take care of the compatibility of createAlignedTimeseriesPlan in mlog of old versions. There's no tagOffset, tag or attribute in that, which means we may check whether the buffer has remaining when deserialize the plan of old versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #5191: [IOTDB-2524] Aligned Timeseries support tags and attributes
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #5191:
URL: https://github.com/apache/iotdb/pull/5191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org