You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "PatrickRen (via GitHub)" <gi...@apache.org> on 2023/10/09 10:08:37 UTC
[PR] [FLINK-33219][connector/kafka] Add new archunit violation messages introduced by FLINK-31804 [flink-connector-kafka]
PatrickRen opened a new pull request, #56:
URL: https://github.com/apache/flink-connector-kafka/pull/56
The reason we add new violation messages instead of update existing ones is that the patch of FLINK-31804 is only applied after Flink 1.18. We need to make sure the CI could run successfully for Flink versions before and after that.
If Kafka connector decides to drop support for versions before 1.18 in the future, please re-freeze the violations then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33219][connector/kafka] Add new archunit violation messages introduced by FLINK-31804 [flink-connector-kafka]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #56:
URL: https://github.com/apache/flink-connector-kafka/pull/56#issuecomment-1752720601
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33219][connector/kafka] Add new archunit violation messages introduced by FLINK-31804 [flink-connector-kafka]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #56:
URL: https://github.com/apache/flink-connector-kafka/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33219][connector/kafka] Add new archunit violation messages introduced by FLINK-31804 [flink-connector-kafka]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #56:
URL: https://github.com/apache/flink-connector-kafka/pull/56#issuecomment-1752946580
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33219][connector/kafka] Add new archunit violation messages introduced by FLINK-31804 [flink-connector-kafka]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #56:
URL: https://github.com/apache/flink-connector-kafka/pull/56#discussion_r1350181266
##########
.github/workflows/push_pr.yml:
##########
@@ -23,6 +23,10 @@ concurrency:
cancel-in-progress: true
jobs:
compile_and_test:
+ strategy:
+ matrix:
+ flink: [ 1.17-SNAPSHOT, 1.18-SNAPSHOT ]
Review Comment:
```suggestion
flink: [ 1.17.1, 1.18-SNAPSHOT ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org