[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r518931251



##########
File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java
##########
@@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsRef ir) {
     return br;
   }
 
-  static String getRandomString(Random random) {
+  public static String getRandomString(Random random) {

Review comment:
       If you're going to make this method public... I think even a tiny bit of documentation would be helpful.  Like maybe recommend callers consider the methods Dawid mentioned in RandomizedTesting _instead_.  After all, we're only making this public for some test in misc to call it.  We aren't signaling to all of Lucene, Solr, and any of the plugin writers, that we've got some awesome random string generating that everyone should use :-)
   
   FWIW I prefer that we maintain less code and use whatever's in RandomizedTesting when possible, but I won't stand in the way of your judgement here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org