You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/21 16:17:22 UTC
[GitHub] [zookeeper] eolivelli opened a new pull request #1258:
ZOOKEEPER-3733 Fix issues reported in 3.6.0rc3
eolivelli opened a new pull request #1258: ZOOKEEPER-3733 Fix issues reported in 3.6.0rc3
URL: https://github.com/apache/zookeeper/pull/1258
- metrics library LICENSE file has wrong file name
- spotbugs is not passing when '-SNAPSHOT' suffix is removed because the Info.java interface sets a null value for "qualifier"
- the name of the directory inside the source tarbal is not consistent with the file name and with 3.5 tradition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1258: ZOOKEEPER-3733 Fix
issues reported in 3.6.0rc3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1258: ZOOKEEPER-3733 Fix issues reported in 3.6.0rc3
URL: https://github.com/apache/zookeeper/pull/1258#issuecomment-590100806
Add -Papache-release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1258: ZOOKEEPER-3733 Fix
issues reported in 3.6.0rc3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1258: ZOOKEEPER-3733 Fix issues reported in 3.6.0rc3
URL: https://github.com/apache/zookeeper/pull/1258#issuecomment-590047860
please also commit #1262 as it is another blocker for the release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1258: ZOOKEEPER-3733 Fix
issues reported in 3.6.0rc3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1258: ZOOKEEPER-3733 Fix issues reported in 3.6.0rc3
URL: https://github.com/apache/zookeeper/pull/1258#issuecomment-590100760
It is not the righet page,
The is one specific page for 3.6 branch
Enrico
Il Dom 23 Feb 2020, 18:06 Patrick Hunt <no...@github.com> ha
scritto:
> This looks like metrics is addressed but the source artifact is not being
> generated (bin is generated though). I'm following the "building" steps
> here:
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven
>
> ⌂141% [phunt:~/dev/zookeeper-trunk] PR_TOOL_MERGE_PR_1258_MASTER+ ± mvn -v
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec
> Java version: 1.8.0_231, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_231.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac"
>
> mvn clean install -DskipTests
> .. success...
>
> ⌂180% [phunt:~/dev/zookeeper-trunk] PR_TOOL_MERGE_PR_1258_MASTER+ 50s ±
> find . -name "*.gz"
> ./zookeeper-assembly/target/apache-zookeeper-3.7.0-SNAPSHOT-bin.tar.gz
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zookeeper/pull/1258?email_source=notifications&email_token=ACIHZNVWPYKWDQ5KBN2Y6DDREKUINA5CNFSM4KZGCTLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWBJWI#issuecomment-590091481>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACIHZNUU66VSJ2J3BDHF7PTREKUINANCNFSM4KZGCTLA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #1258: ZOOKEEPER-3733 Fix
issues reported in 3.6.0rc3
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1258: ZOOKEEPER-3733 Fix issues reported in 3.6.0rc3
URL: https://github.com/apache/zookeeper/pull/1258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1258: ZOOKEEPER-3733 Fix
issues reported in 3.6.0rc3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1258: ZOOKEEPER-3733 Fix issues reported in 3.6.0rc3
URL: https://github.com/apache/zookeeper/pull/1258#issuecomment-590112744
And you will find it inside 'target' directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] phunt commented on issue #1258: ZOOKEEPER-3733 Fix
issues reported in 3.6.0rc3
Posted by GitBox <gi...@apache.org>.
phunt commented on issue #1258: ZOOKEEPER-3733 Fix issues reported in 3.6.0rc3
URL: https://github.com/apache/zookeeper/pull/1258#issuecomment-590091481
This looks like metrics is addressed but the source artifact is not being generated (bin is generated though). I'm following the "building" steps here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven
⌂141% [phunt:~/dev/zookeeper-trunk] PR_TOOL_MERGE_PR_1258_MASTER+ ± mvn -v
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec
Java version: 1.8.0_231, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_231.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac"
mvn clean install -DskipTests
.. success...
⌂180% [phunt:~/dev/zookeeper-trunk] PR_TOOL_MERGE_PR_1258_MASTER+ 50s ± find . -name "*.gz"
./zookeeper-assembly/target/apache-zookeeper-3.7.0-SNAPSHOT-bin.tar.gz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services