You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ivan Popov (JIRA)" <ji...@apache.org> on 2007/07/03 14:51:04 UTC

[jira] Created: (HARMONY-4323) [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes

[jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes
-------------------------------------------------------------------------------------

                 Key: HARMONY-4323
                 URL: https://issues.apache.org/jira/browse/HARMONY-4323
             Project: Harmony
          Issue Type: Bug
          Components: JDK
         Environment: Windows/x86, Linux/x86
            Reporter: Ivan Popov


JDWP spec does not say anyting about classes returned by AllClasses command. However, JDI spec for VirtualMachine.allClasses() reads:

  The returned list will include reference types loaded at least 
  to the point of preparation and types (like array) for which 
  preparation is not defined. 

It is unclear who should perform filtering for classes: JDI or JDWP implementation. But it looks like JDWP agent from RI never reports unprepared classes. It makes sense to adjust Harmony's JDWP agent to filter out unprepared classes.

This issue may cause intermittent failures of the following JDWP stress tests:

  org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE003.RefTypeTest003
  org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE004.RefTypeTest004


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-4323) [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-4323.
----------------------------------------

    Resolution: Fixed

Patch applied at 558746. Please check that the bug is fixed for you.

> [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4323
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows/x86, Linux/x86
>            Reporter: Ivan Popov
>            Assignee: Gregory Shimansky
>         Attachments: H4323_jdwp_agent_all_classes.patch
>
>
> JDWP spec does not say anyting about classes returned by AllClasses command. However, JDI spec for VirtualMachine.allClasses() reads:
>   The returned list will include reference types loaded at least 
>   to the point of preparation and types (like array) for which 
>   preparation is not defined. 
> It is unclear who should perform filtering for classes: JDI or JDWP implementation. But it looks like JDWP agent from RI never reports unprepared classes. It makes sense to adjust Harmony's JDWP agent to filter out unprepared classes.
> This issue may cause intermittent failures of the following JDWP stress tests:
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE003.RefTypeTest003
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE004.RefTypeTest004

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4323) [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes

Posted by "Ivan Popov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509866 ] 

Ivan Popov commented on HARMONY-4323:
-------------------------------------

Pavel, JVMTI spec also says nothing about returning unprepared classes by the corresponding JVMTI function GetLoadedClasses(). However, JVMTI provides function GetClassStatus() which may return info about class preparation status of the returned classes.


> [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4323
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows/x86, Linux/x86
>            Reporter: Ivan Popov
>         Attachments: H4323_jdwp_agent_all_classes.patch
>
>
> JDWP spec does not say anyting about classes returned by AllClasses command. However, JDI spec for VirtualMachine.allClasses() reads:
>   The returned list will include reference types loaded at least 
>   to the point of preparation and types (like array) for which 
>   preparation is not defined. 
> It is unclear who should perform filtering for classes: JDI or JDWP implementation. But it looks like JDWP agent from RI never reports unprepared classes. It makes sense to adjust Harmony's JDWP agent to filter out unprepared classes.
> This issue may cause intermittent failures of the following JDWP stress tests:
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE003.RefTypeTest003
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE004.RefTypeTest004

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4323) [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes

Posted by "Ivan Popov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Popov updated HARMONY-4323:
--------------------------------

    Attachment: H4323_jdwp_agent_all_classes.patch

Attached patch 'H4323_jdwp_agent_all_classes.patch' fixes JDWP agent to filter out unprepared classes. This patch should be applied after patch for HARMONY-2894, otherwise it will warn about shifted hunks.

With this patch affected JDWP tests pass against Harmony M2 builds after applying patch for HARMONY-4322.


> [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4323
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows/x86, Linux/x86
>            Reporter: Ivan Popov
>         Attachments: H4323_jdwp_agent_all_classes.patch
>
>
> JDWP spec does not say anyting about classes returned by AllClasses command. However, JDI spec for VirtualMachine.allClasses() reads:
>   The returned list will include reference types loaded at least 
>   to the point of preparation and types (like array) for which 
>   preparation is not defined. 
> It is unclear who should perform filtering for classes: JDI or JDWP implementation. But it looks like JDWP agent from RI never reports unprepared classes. It makes sense to adjust Harmony's JDWP agent to filter out unprepared classes.
> This issue may cause intermittent failures of the following JDWP stress tests:
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE003.RefTypeTest003
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE004.RefTypeTest004

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4323) [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes

Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509859 ] 

Pavel Pervov commented on HARMONY-4323:
---------------------------------------

May it be the responsibility of JVM TI implementation to filter out classes, which are not yet prepared from reporting it to JDWP?

> [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4323
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows/x86, Linux/x86
>            Reporter: Ivan Popov
>
> JDWP spec does not say anyting about classes returned by AllClasses command. However, JDI spec for VirtualMachine.allClasses() reads:
>   The returned list will include reference types loaded at least 
>   to the point of preparation and types (like array) for which 
>   preparation is not defined. 
> It is unclear who should perform filtering for classes: JDI or JDWP implementation. But it looks like JDWP agent from RI never reports unprepared classes. It makes sense to adjust Harmony's JDWP agent to filter out unprepared classes.
> This issue may cause intermittent failures of the following JDWP stress tests:
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE003.RefTypeTest003
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE004.RefTypeTest004

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4323) [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes

Posted by "Ivan Popov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510877 ] 

Ivan Popov commented on HARMONY-4323:
-------------------------------------

Patches for this issue should be applied after patches for patch for HARMONY-2894 and HARMONY-3508, otherwise it may break other pending JDWP patches.

> [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4323
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows/x86, Linux/x86
>            Reporter: Ivan Popov
>         Attachments: H4323_jdwp_agent_all_classes.patch
>
>
> JDWP spec does not say anyting about classes returned by AllClasses command. However, JDI spec for VirtualMachine.allClasses() reads:
>   The returned list will include reference types loaded at least 
>   to the point of preparation and types (like array) for which 
>   preparation is not defined. 
> It is unclear who should perform filtering for classes: JDI or JDWP implementation. But it looks like JDWP agent from RI never reports unprepared classes. It makes sense to adjust Harmony's JDWP agent to filter out unprepared classes.
> This issue may cause intermittent failures of the following JDWP stress tests:
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE003.RefTypeTest003
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE004.RefTypeTest004

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-4323) [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky reassigned HARMONY-4323:
------------------------------------------

    Assignee: Gregory Shimansky

> [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4323
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows/x86, Linux/x86
>            Reporter: Ivan Popov
>            Assignee: Gregory Shimansky
>         Attachments: H4323_jdwp_agent_all_classes.patch
>
>
> JDWP spec does not say anyting about classes returned by AllClasses command. However, JDI spec for VirtualMachine.allClasses() reads:
>   The returned list will include reference types loaded at least 
>   to the point of preparation and types (like array) for which 
>   preparation is not defined. 
> It is unclear who should perform filtering for classes: JDI or JDWP implementation. But it looks like JDWP agent from RI never reports unprepared classes. It makes sense to adjust Harmony's JDWP agent to filter out unprepared classes.
> This issue may cause intermittent failures of the following JDWP stress tests:
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE003.RefTypeTest003
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE004.RefTypeTest004

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4323) [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes

Posted by "Ivan Popov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Popov updated HARMONY-4323:
--------------------------------

    Patch Info: [Patch Available]

> [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4323
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows/x86, Linux/x86
>            Reporter: Ivan Popov
>         Attachments: H4323_jdwp_agent_all_classes.patch
>
>
> JDWP spec does not say anyting about classes returned by AllClasses command. However, JDI spec for VirtualMachine.allClasses() reads:
>   The returned list will include reference types loaded at least 
>   to the point of preparation and types (like array) for which 
>   preparation is not defined. 
> It is unclear who should perform filtering for classes: JDI or JDWP implementation. But it looks like JDWP agent from RI never reports unprepared classes. It makes sense to adjust Harmony's JDWP agent to filter out unprepared classes.
> This issue may cause intermittent failures of the following JDWP stress tests:
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE003.RefTypeTest003
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE004.RefTypeTest004

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-4323) [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes

Posted by "Ivan Popov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Popov closed HARMONY-4323.
-------------------------------


Thanks, Gregory.
Verified in harmony-jdk-r558928, closing this issue.


> [jdktools][jpda] JDWP commands VirtualMachine.AllClasses returns not prepared classes
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4323
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows/x86, Linux/x86
>            Reporter: Ivan Popov
>            Assignee: Gregory Shimansky
>         Attachments: H4323_jdwp_agent_all_classes.patch
>
>
> JDWP spec does not say anyting about classes returned by AllClasses command. However, JDI spec for VirtualMachine.allClasses() reads:
>   The returned list will include reference types loaded at least 
>   to the point of preparation and types (like array) for which 
>   preparation is not defined. 
> It is unclear who should perform filtering for classes: JDI or JDWP implementation. But it looks like JDWP agent from RI never reports unprepared classes. It makes sense to adjust Harmony's JDWP agent to filter out unprepared classes.
> This issue may cause intermittent failures of the following JDWP stress tests:
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE003.RefTypeTest003
>   org.apache.harmony.test.stress.jpda.jdwp.scenario.REFTYPE004.RefTypeTest004

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.