You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by jd...@apache.org on 2010/07/31 01:41:03 UTC
svn commit: r980994 - in /hbase/branches/0.89.20100726: CHANGES.txt
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java
Author: jdcryans
Date: Fri Jul 30 23:41:02 2010
New Revision: 980994
URL: http://svn.apache.org/viewvc?rev=980994&view=rev
Log:
HBASE-2892 Replication metrics aren't updated
Modified:
hbase/branches/0.89.20100726/CHANGES.txt
hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java
hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java
Modified: hbase/branches/0.89.20100726/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/branches/0.89.20100726/CHANGES.txt?rev=980994&r1=980993&r2=980994&view=diff
==============================================================================
--- hbase/branches/0.89.20100726/CHANGES.txt (original)
+++ hbase/branches/0.89.20100726/CHANGES.txt Fri Jul 30 23:41:02 2010
@@ -1204,6 +1204,7 @@ Release 0.20.0 - Tue Sep 8 12:53:05 PDT
(Alexey Kovyrin via Stack)
HBASE-2531 32-bit encoding of regionnames waaaaaaayyyyy too susceptible to
hash clashes (Kannan Muthukkaruppan via Stack)
+ HBASE-2892 Replication metrics aren't updated
IMPROVEMENTS
HBASE-1089 Add count of regions on filesystem to master UI; add percentage
Modified: hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java?rev=980994&r1=980993&r2=980994&view=diff
==============================================================================
--- hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java (original)
+++ hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java Fri Jul 30 23:41:02 2010
@@ -58,8 +58,6 @@ public class ReplicationSinkMetrics impl
metricsRecord = MetricsUtil.createRecord(context, "replication");
metricsRecord.setTag("RegionServer", name);
context.registerUpdater(this);
- // Add jvmmetrics.
- JvmMetrics.init("RegionServer", name);
// export for JMX
new ReplicationStatistics(this.registry, "ReplicationSink");
}
@@ -78,5 +76,6 @@ public class ReplicationSinkMetrics impl
this.appliedBatchesRate.pushMetric(this.metricsRecord);
this.ageOfLastAppliedOp.pushMetric(this.metricsRecord);
}
+ this.metricsRecord.update();
}
}
Modified: hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java?rev=980994&r1=980993&r2=980994&view=diff
==============================================================================
--- hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java (original)
+++ hbase/branches/0.89.20100726/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java Fri Jul 30 23:41:02 2010
@@ -73,8 +73,6 @@ public class ReplicationSourceMetrics im
metricsRecord = MetricsUtil.createRecord(context, "replication");
metricsRecord.setTag("RegionServer", name);
context.registerUpdater(this);
- // Add jvmmetrics.
- JvmMetrics.init("RegionServer", name);
// export for JMX
new ReplicationStatistics(this.registry, "ReplicationSource for " + id);
}
@@ -97,5 +95,6 @@ public class ReplicationSourceMetrics im
this.ageOfLastShippedOp.pushMetric(this.metricsRecord);
this.sizeOfLogQueue.pushMetric(this.metricsRecord);
}
+ this.metricsRecord.update();
}
}