[GitHub] [incubator-superset] fx19880617 commented on pull request #9954: fix: pinot select query logic

[GitBox <gi...@apache.org>]

fx19880617 commented on pull request #9954:
URL: https://github.com/apache/incubator-superset/pull/9954#issuecomment-637743106


   > > No need to remove groupby fields from selection list anymore.
   > 
   > Is this because it's been addressed in a newer version of Pinot? Do we not case about people on older versions? [Genuine questions] idk how the Pinot community distribution across versions is...
   
   Thanks for bring this up!
   
   In general, it won't change the behavior for old users as old pinot just ignores those fields, no matter the presence and always assume they are there. That's the reason we removed them to make query looks more like Pinot Style.
   
   This code change is for `pinotdb-pypi` >=0.3.1, which leverages new Pinot SQL Endpoint(available on Pinot 0.3.0+)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org