You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/11/13 15:52:42 UTC

[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new pull request #1233: delete class App, let spring manage connectionFactory

Technoboy- opened a new pull request #1233: delete class App, let spring manage connectionFactory
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1233
 
 
   in current project , we use two way to get mapper , Autowired and init method like ProcessDao.
   they are misunderstanding.  first , codes are duplicate , second , why not only Autowired or ProcessDao style?
   so we decide to keep code clean and simplify, we choose Autowired.
   that mean , we have to add annotation for ConnectionFactory, and then remove all the code like : DaoFactory.getDaoInstance(AlertDao.class);
   that's why i pull the request。
   but still remember , Alert module is not spring project , so AlertDao keeps the original codes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services