You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by joel-hamill <gi...@git.apache.org> on 2017/09/14 19:36:46 UTC
[GitHub] kafka-site pull request #77: DOCS-90 - Add streams child topics to left-hand...
GitHub user joel-hamill opened a pull request:
https://github.com/apache/kafka-site/pull/77
DOCS-90 - Add streams child topics to left-hand nav
https://confluentinc.atlassian.net/browse/DOCS-90
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joel-hamill/kafka-site joel-hamill/nav-fixes-streams
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka-site/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit 0dec1d9f53ed3d16b1cccb531124e9ab0fed2be1
Author: Joel Hamill <jo...@joel-hamill-confluent.local>
Date: 2017-09-14T19:36:19Z
DOCS-90 - Add streams child topics to left-hand nav
----
---
[GitHub] kafka-site pull request #77: MINOR: Add streams child topics to left-hand na...
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/77#discussion_r139275996
--- Diff: index.html ---
@@ -7,17 +7,17 @@
<a href="/documentation/#producerapi" class="desc-item">
<h2>Publish & subscribe</h2>
<p>to streams of data like a messaging system</p>
- <span class="desc-item__cta">Learn more »</span>
+ <span class="desc-item__cta">Learn about APIs »</span>
</a>
<a href="/documentation/streams" class="desc-item">
<h2>Process</h2>
<p>streams of data efficiently and in real time</p>
- <span class="desc-item__cta">Learn more »</span>
+ <span class="desc-item__cta">Learn about Streams »</span>
</a>
<a href="/intro#kafka_storage" class="desc-item">
<h2>Store</h2>
<p>streams of data safely in a distributed replicated cluster</p>
- <span class="desc-item__cta">Learn more »</span>
+ <span class="desc-item__cta">Learn about Storage »</span>
--- End diff --
`Learn about storage architecture design`?
---
[GitHub] kafka-site issue #77: MINOR: Add streams child topics to left-hand nav
Posted by dguy <gi...@git.apache.org>.
Github user dguy commented on the issue:
https://github.com/apache/kafka-site/pull/77
@miguno
---
[GitHub] kafka-site issue #77: MINOR: Update verbiage on landing page https://kafka.a...
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on the issue:
https://github.com/apache/kafka-site/pull/77
@miguno done https://github.com/apache/kafka-site/pull/77#issuecomment-333752239
---
[GitHub] kafka-site issue #77: MINOR: Update verbiage on landing page https://kafka.a...
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on the issue:
https://github.com/apache/kafka-site/pull/77
ping @guozhangwang for merge
---
[GitHub] kafka-site issue #77: MINOR: Update verbiage on landing page https://kafka.a...
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on the issue:
https://github.com/apache/kafka-site/pull/77
LGTM. Merged to asf-site.
---
[GitHub] kafka-site pull request #77: MINOR: Add streams child topics to left-hand na...
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/77#discussion_r139275915
--- Diff: index.html ---
@@ -7,17 +7,17 @@
<a href="/documentation/#producerapi" class="desc-item">
<h2>Publish & subscribe</h2>
<p>to streams of data like a messaging system</p>
- <span class="desc-item__cta">Learn more »</span>
+ <span class="desc-item__cta">Learn about APIs »</span>
--- End diff --
`Learn about producer and consumer`?
---
[GitHub] kafka-site pull request #77: MINOR: Add streams child topics to left-hand na...
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/77#discussion_r142175889
--- Diff: includes/_nav.htm ---
@@ -11,6 +11,12 @@
<a class="nav__item nav__sub__item" href="/documentation#gettingStarted">getting started</a>
<a class="nav__item nav__sub__item" href="/documentation#api">APIs</a>
<a class="b-nav__streams nav__item nav__sub__item" href="/documentation/streams">kafka streams</a>
+ <!-- Streams child pages -->
--- End diff --
@guozhangwang here you go:
---
[GitHub] kafka-site issue #77: MINOR: Add streams child topics to left-hand nav
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on the issue:
https://github.com/apache/kafka-site/pull/77
@dguy i don't think these files are in https://github.com/apache/kafka/tree/trunk/docs. these are changes specifically to the header/footer/nav, and files that are specific to the kafka-site repo.
---
[GitHub] kafka-site issue #77: MINOR: Add streams child topics to left-hand nav
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on the issue:
https://github.com/apache/kafka-site/pull/77
after talking with @derrickdoo, I have removed the changes to the left-hand nav.
---
[GitHub] kafka-site pull request #77: MINOR: Add streams child topics to left-hand na...
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/77#discussion_r139275946
--- Diff: index.html ---
@@ -7,17 +7,17 @@
<a href="/documentation/#producerapi" class="desc-item">
<h2>Publish & subscribe</h2>
<p>to streams of data like a messaging system</p>
- <span class="desc-item__cta">Learn more »</span>
+ <span class="desc-item__cta">Learn about APIs »</span>
</a>
<a href="/documentation/streams" class="desc-item">
<h2>Process</h2>
<p>streams of data efficiently and in real time</p>
- <span class="desc-item__cta">Learn more »</span>
+ <span class="desc-item__cta">Learn about Streams »</span>
--- End diff --
`Learn about Streams API`?
---
[GitHub] kafka-site issue #77: MINOR: Add streams child topics to left-hand nav
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on the issue:
https://github.com/apache/kafka-site/pull/77
@derrickdoo ping ^
---
[GitHub] kafka-site pull request #77: MINOR: Add streams child topics to left-hand na...
Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/77#discussion_r139275998
--- Diff: includes/_nav.htm ---
@@ -11,6 +11,12 @@
<a class="nav__item nav__sub__item" href="/documentation#gettingStarted">getting started</a>
<a class="nav__item nav__sub__item" href="/documentation#api">APIs</a>
<a class="b-nav__streams nav__item nav__sub__item" href="/documentation/streams">kafka streams</a>
+ <!-- Streams child pages -->
--- End diff --
Could you paste a screenshot of this change?
---
[GitHub] kafka-site pull request #77: MINOR: Update verbiage on landing page https://...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka-site/pull/77
---
[GitHub] kafka-site issue #77: MINOR: Add streams child topics to left-hand nav
Posted by dguy <gi...@git.apache.org>.
Github user dguy commented on the issue:
https://github.com/apache/kafka-site/pull/77
as per: https://github.com/apache/kafka-site/pull/78#issuecomment-329644776
---
[GitHub] kafka-site issue #77: DOCS-90 - Add streams child topics to left-hand nav
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on the issue:
https://github.com/apache/kafka-site/pull/77
ping for review @guozhangwang @dguy
---
[GitHub] kafka-site issue #77: MINOR: Add streams child topics to left-hand nav
Posted by miguno <gi...@git.apache.org>.
Github user miguno commented on the issue:
https://github.com/apache/kafka-site/pull/77
Could you please edit/update the PR title then?
I understand that this PR is now a change to the content pane of the main page (kafka.apache.org) only?
---