You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/29 09:09:31 UTC

[GitHub] [incubator-superset] villebro commented on a change in pull request #11103: fix: echarts timeseries groupby

villebro commented on a change in pull request #11103:
URL: https://github.com/apache/incubator-superset/pull/11103#discussion_r496560851



##########
File path: superset/charts/schemas.py
##########
@@ -718,6 +718,7 @@ class ChartDataQueryObjectSchema(Schema):
     )
     groupby = fields.List(
         fields.String(description="Columns by which to group the query.",),
+        allow_none=True,

Review comment:
       `QueryObject` automatically does `self.groupby = groupby or []` in the constructor, so no need to require a `fields.List`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org