You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Austin Cawley-Edwards <au...@gmail.com> on 2020/06/13 20:40:50 UTC
Moving in and Modify Dependency Source
Hi all,
I'm working on [FLINK-10195] on the RabbitMQ connector which involves
modifying some of the RMQ client source code (that has been moved out of
that package) and bringing it into Flink. The RMQ client code is
triple-licensed under Mozilla Public License 1.1 ("MPL"), the GNU General
Public License version 2 ("GPL"), and the Apache License version 2 ("ASL").
Does anyone have experience doing something similar/ what I would need to
do in terms of the license headers in the Flink source files?
Thank you,
Austin
[FLINK-10195]: https://issues.apache.org/jira/browse/FLINK-10195
Re: Moving in and Modify Dependency Source
Posted by Robert Metzger <rm...@apache.org>.
We have documented how the licensing works here:
https://cwiki.apache.org/confluence/display/FLINK/Licensing
(There's a section on the "licenses directory")
In this case, I don't think you'll need to include the apache license in
the licenses/ directory (because it's the Apache license)
On Tue, Jun 16, 2020 at 1:42 AM Austin Cawley-Edwards <
austin.cawley@gmail.com> wrote:
> Ah, missed Till's response -- thanks as well!
>
> I'll add those headers to the files, so just now wondering about including
> the licenses/ notice in the RMQ connector resources.
>
> On Mon, Jun 15, 2020 at 7:40 PM Austin Cawley-Edwards <
> austin.cawley@gmail.com> wrote:
>
> > Hey Robert,
> >
> > Thanks for getting back to me! Just wasn't sure on the license header
> > requirements for the CI checks in Flink. Not too experienced with working
> > with licenses, especially in large open-source projects. Since we would
> be
> > using APL 2 (and from this link[1] we need to state changes, include the
> > copyright, add to a notice file, add to licenses), would I just include
> > their copyright at the top of the file and then state the changes I've
> made
> > there, or somewhere else? Do I need to create a new NOTICE file/ licenses
> > in the RMQ connector resources or add it to another file?
> >
> > Sorry for all the questions! ... is there anywhere in the docs that
> > addresses this?
> >
> > Best + thanks again,
> > Austin
> >
> > [1]: https://tldrlegal.com/license/apache-license-2.0-%28apache-2.0%29
> >
> > On Mon, Jun 15, 2020 at 4:20 AM Robert Metzger <rm...@apache.org>
> > wrote:
> >
> >> Hi Austin,
> >> Thanks for working on the RMQ connector! There seem to be a few users
> >> affected by that issue.
> >>
> >> The GitHub page confirms that users can choose from the three licenses:
> >> https://github.com/rabbitmq/rabbitmq-java-client#license:
> >>
> >> > This means that the user can consider the library to be licensed under
> >> any
> >> > of the licenses from the list above. For example, you may choose the
> >> > Apache Public License 2.0 and include this client into a commercial
> >> > product. Projects that are licensed under the GPLv2 may choose GPLv2,
> >> and
> >> > so on.
> >>
> >>
> >> Best,
> >> Robert
> >>
> >> On Mon, Jun 15, 2020 at 8:59 AM Till Rohrmann <tr...@apache.org>
> >> wrote:
> >>
> >> > Hi Austin,
> >> >
> >> > usually if source code is multi licensed then this means that the user
> >> can
> >> > choose the license under which he wants it to use. In our case it
> would
> >> be
> >> > the Apache License version 2. But you should check the license text to
> >> make
> >> > sure that this has not been forbidden explicitly.
> >> >
> >> > When copying code from another project, the practice is to annotate it
> >> with
> >> > a comment stating from where the code was obtained. So in your case
> you
> >> > would give these files the ASL license header and add a comment to the
> >> > source code from where it was copied.
> >> >
> >> > Cheers,
> >> > Till
> >> >
> >> > On Sat, Jun 13, 2020 at 10:41 PM Austin Cawley-Edwards <
> >> > austin.cawley@gmail.com> wrote:
> >> >
> >> > > Hi all,
> >> > >
> >> > > I'm working on [FLINK-10195] on the RabbitMQ connector which
> involves
> >> > > modifying some of the RMQ client source code (that has been moved
> out
> >> of
> >> > > that package) and bringing it into Flink. The RMQ client code is
> >> > > triple-licensed under Mozilla Public License 1.1 ("MPL"), the GNU
> >> General
> >> > > Public License version 2 ("GPL"), and the Apache License version 2
> >> > ("ASL").
> >> > >
> >> > > Does anyone have experience doing something similar/ what I would
> >> need to
> >> > > do in terms of the license headers in the Flink source files?
> >> > >
> >> > > Thank you,
> >> > > Austin
> >> > >
> >> > > [FLINK-10195]: https://issues.apache.org/jira/browse/FLINK-10195
> >> > >
> >> >
> >>
> >
>
Re: Moving in and Modify Dependency Source
Posted by Austin Cawley-Edwards <au...@gmail.com>.
Ah, missed Till's response -- thanks as well!
I'll add those headers to the files, so just now wondering about including
the licenses/ notice in the RMQ connector resources.
On Mon, Jun 15, 2020 at 7:40 PM Austin Cawley-Edwards <
austin.cawley@gmail.com> wrote:
> Hey Robert,
>
> Thanks for getting back to me! Just wasn't sure on the license header
> requirements for the CI checks in Flink. Not too experienced with working
> with licenses, especially in large open-source projects. Since we would be
> using APL 2 (and from this link[1] we need to state changes, include the
> copyright, add to a notice file, add to licenses), would I just include
> their copyright at the top of the file and then state the changes I've made
> there, or somewhere else? Do I need to create a new NOTICE file/ licenses
> in the RMQ connector resources or add it to another file?
>
> Sorry for all the questions! ... is there anywhere in the docs that
> addresses this?
>
> Best + thanks again,
> Austin
>
> [1]: https://tldrlegal.com/license/apache-license-2.0-%28apache-2.0%29
>
> On Mon, Jun 15, 2020 at 4:20 AM Robert Metzger <rm...@apache.org>
> wrote:
>
>> Hi Austin,
>> Thanks for working on the RMQ connector! There seem to be a few users
>> affected by that issue.
>>
>> The GitHub page confirms that users can choose from the three licenses:
>> https://github.com/rabbitmq/rabbitmq-java-client#license:
>>
>> > This means that the user can consider the library to be licensed under
>> any
>> > of the licenses from the list above. For example, you may choose the
>> > Apache Public License 2.0 and include this client into a commercial
>> > product. Projects that are licensed under the GPLv2 may choose GPLv2,
>> and
>> > so on.
>>
>>
>> Best,
>> Robert
>>
>> On Mon, Jun 15, 2020 at 8:59 AM Till Rohrmann <tr...@apache.org>
>> wrote:
>>
>> > Hi Austin,
>> >
>> > usually if source code is multi licensed then this means that the user
>> can
>> > choose the license under which he wants it to use. In our case it would
>> be
>> > the Apache License version 2. But you should check the license text to
>> make
>> > sure that this has not been forbidden explicitly.
>> >
>> > When copying code from another project, the practice is to annotate it
>> with
>> > a comment stating from where the code was obtained. So in your case you
>> > would give these files the ASL license header and add a comment to the
>> > source code from where it was copied.
>> >
>> > Cheers,
>> > Till
>> >
>> > On Sat, Jun 13, 2020 at 10:41 PM Austin Cawley-Edwards <
>> > austin.cawley@gmail.com> wrote:
>> >
>> > > Hi all,
>> > >
>> > > I'm working on [FLINK-10195] on the RabbitMQ connector which involves
>> > > modifying some of the RMQ client source code (that has been moved out
>> of
>> > > that package) and bringing it into Flink. The RMQ client code is
>> > > triple-licensed under Mozilla Public License 1.1 ("MPL"), the GNU
>> General
>> > > Public License version 2 ("GPL"), and the Apache License version 2
>> > ("ASL").
>> > >
>> > > Does anyone have experience doing something similar/ what I would
>> need to
>> > > do in terms of the license headers in the Flink source files?
>> > >
>> > > Thank you,
>> > > Austin
>> > >
>> > > [FLINK-10195]: https://issues.apache.org/jira/browse/FLINK-10195
>> > >
>> >
>>
>
Re: Moving in and Modify Dependency Source
Posted by Austin Cawley-Edwards <au...@gmail.com>.
Hey Robert,
Thanks for getting back to me! Just wasn't sure on the license header
requirements for the CI checks in Flink. Not too experienced with working
with licenses, especially in large open-source projects. Since we would be
using APL 2 (and from this link[1] we need to state changes, include the
copyright, add to a notice file, add to licenses), would I just include
their copyright at the top of the file and then state the changes I've made
there, or somewhere else? Do I need to create a new NOTICE file/ licenses
in the RMQ connector resources or add it to another file?
Sorry for all the questions! ... is there anywhere in the docs that
addresses this?
Best + thanks again,
Austin
[1]: https://tldrlegal.com/license/apache-license-2.0-%28apache-2.0%29
On Mon, Jun 15, 2020 at 4:20 AM Robert Metzger <rm...@apache.org> wrote:
> Hi Austin,
> Thanks for working on the RMQ connector! There seem to be a few users
> affected by that issue.
>
> The GitHub page confirms that users can choose from the three licenses:
> https://github.com/rabbitmq/rabbitmq-java-client#license:
>
> > This means that the user can consider the library to be licensed under
> any
> > of the licenses from the list above. For example, you may choose the
> > Apache Public License 2.0 and include this client into a commercial
> > product. Projects that are licensed under the GPLv2 may choose GPLv2, and
> > so on.
>
>
> Best,
> Robert
>
> On Mon, Jun 15, 2020 at 8:59 AM Till Rohrmann <tr...@apache.org>
> wrote:
>
> > Hi Austin,
> >
> > usually if source code is multi licensed then this means that the user
> can
> > choose the license under which he wants it to use. In our case it would
> be
> > the Apache License version 2. But you should check the license text to
> make
> > sure that this has not been forbidden explicitly.
> >
> > When copying code from another project, the practice is to annotate it
> with
> > a comment stating from where the code was obtained. So in your case you
> > would give these files the ASL license header and add a comment to the
> > source code from where it was copied.
> >
> > Cheers,
> > Till
> >
> > On Sat, Jun 13, 2020 at 10:41 PM Austin Cawley-Edwards <
> > austin.cawley@gmail.com> wrote:
> >
> > > Hi all,
> > >
> > > I'm working on [FLINK-10195] on the RabbitMQ connector which involves
> > > modifying some of the RMQ client source code (that has been moved out
> of
> > > that package) and bringing it into Flink. The RMQ client code is
> > > triple-licensed under Mozilla Public License 1.1 ("MPL"), the GNU
> General
> > > Public License version 2 ("GPL"), and the Apache License version 2
> > ("ASL").
> > >
> > > Does anyone have experience doing something similar/ what I would need
> to
> > > do in terms of the license headers in the Flink source files?
> > >
> > > Thank you,
> > > Austin
> > >
> > > [FLINK-10195]: https://issues.apache.org/jira/browse/FLINK-10195
> > >
> >
>
Re: Moving in and Modify Dependency Source
Posted by Robert Metzger <rm...@apache.org>.
Hi Austin,
Thanks for working on the RMQ connector! There seem to be a few users
affected by that issue.
The GitHub page confirms that users can choose from the three licenses:
https://github.com/rabbitmq/rabbitmq-java-client#license:
> This means that the user can consider the library to be licensed under any
> of the licenses from the list above. For example, you may choose the
> Apache Public License 2.0 and include this client into a commercial
> product. Projects that are licensed under the GPLv2 may choose GPLv2, and
> so on.
Best,
Robert
On Mon, Jun 15, 2020 at 8:59 AM Till Rohrmann <tr...@apache.org> wrote:
> Hi Austin,
>
> usually if source code is multi licensed then this means that the user can
> choose the license under which he wants it to use. In our case it would be
> the Apache License version 2. But you should check the license text to make
> sure that this has not been forbidden explicitly.
>
> When copying code from another project, the practice is to annotate it with
> a comment stating from where the code was obtained. So in your case you
> would give these files the ASL license header and add a comment to the
> source code from where it was copied.
>
> Cheers,
> Till
>
> On Sat, Jun 13, 2020 at 10:41 PM Austin Cawley-Edwards <
> austin.cawley@gmail.com> wrote:
>
> > Hi all,
> >
> > I'm working on [FLINK-10195] on the RabbitMQ connector which involves
> > modifying some of the RMQ client source code (that has been moved out of
> > that package) and bringing it into Flink. The RMQ client code is
> > triple-licensed under Mozilla Public License 1.1 ("MPL"), the GNU General
> > Public License version 2 ("GPL"), and the Apache License version 2
> ("ASL").
> >
> > Does anyone have experience doing something similar/ what I would need to
> > do in terms of the license headers in the Flink source files?
> >
> > Thank you,
> > Austin
> >
> > [FLINK-10195]: https://issues.apache.org/jira/browse/FLINK-10195
> >
>
Re: Moving in and Modify Dependency Source
Posted by Till Rohrmann <tr...@apache.org>.
Hi Austin,
usually if source code is multi licensed then this means that the user can
choose the license under which he wants it to use. In our case it would be
the Apache License version 2. But you should check the license text to make
sure that this has not been forbidden explicitly.
When copying code from another project, the practice is to annotate it with
a comment stating from where the code was obtained. So in your case you
would give these files the ASL license header and add a comment to the
source code from where it was copied.
Cheers,
Till
On Sat, Jun 13, 2020 at 10:41 PM Austin Cawley-Edwards <
austin.cawley@gmail.com> wrote:
> Hi all,
>
> I'm working on [FLINK-10195] on the RabbitMQ connector which involves
> modifying some of the RMQ client source code (that has been moved out of
> that package) and bringing it into Flink. The RMQ client code is
> triple-licensed under Mozilla Public License 1.1 ("MPL"), the GNU General
> Public License version 2 ("GPL"), and the Apache License version 2 ("ASL").
>
> Does anyone have experience doing something similar/ what I would need to
> do in terms of the license headers in the Flink source files?
>
> Thank you,
> Austin
>
> [FLINK-10195]: https://issues.apache.org/jira/browse/FLINK-10195
>