You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/07 08:27:10 UTC
[GitHub] [incubator-superset] villebro commented on a change in pull request #11173: fix(viz): downgrade exception for missing viz/datasource
villebro commented on a change in pull request #11173:
URL: https://github.com/apache/incubator-superset/pull/11173#discussion_r500829487
##########
File path: superset/views/utils.py
##########
@@ -494,12 +495,21 @@ def check_datasource_perms(
)
)
- viz_obj = get_viz(
- datasource_type=datasource_type,
- datasource_id=datasource_id,
- form_data=form_data,
- force=False,
- )
+ try:
+ viz_obj = get_viz(
+ datasource_type=datasource_type,
+ datasource_id=datasource_id,
+ form_data=form_data,
+ force=False,
+ )
+ except NoResultFound:
+ raise SupersetSecurityException(
+ SupersetError(
+ error_type=SupersetErrorType.UNKNOWN_DATASOURCE_TYPE_ERROR,
+ level=ErrorLevel.ERROR,
+ message="Could not find viz object",
Review comment:
Good point. I'll add translations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org