You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Sylwester Lachiewicz <sl...@gmail.com> on 2020/05/09 20:13:33 UTC
JDK 8 Minimum Requirement for Maven Resolver 2.0
Hi to all,
based on the previous vote to require Java 8 for Maven Core - I would like
to propose setting the same minimum for Maven Resolver 2.0
Maven Resolver is a base component to solve dependencies for Maven. It can
also be used separately from Maven for other projects.
Because Java 7 updates are no longer available, the market is also moving
towards using the newer version of Java 8/11.
Practically the Core requirement means that Resolver has little chance of
being used in Java 7 (see tricks to connect to Central).
Benefits - more programmers can practice coding while improving our
codebase.
What's your opinion on the subject?
https://maven.apache.org/resolver/
Kind regards
Sylwester
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Olivier Lamy <ol...@apache.org>.
+1 Java8 finally....
On Sun, 10 May 2020 at 06:13, Sylwester Lachiewicz <sl...@gmail.com>
wrote:
> Hi to all,
>
> based on the previous vote to require Java 8 for Maven Core - I would like
> to propose setting the same minimum for Maven Resolver 2.0
>
> Maven Resolver is a base component to solve dependencies for Maven. It can
> also be used separately from Maven for other projects.
> Because Java 7 updates are no longer available, the market is also moving
> towards using the newer version of Java 8/11.
> Practically the Core requirement means that Resolver has little chance of
> being used in Java 7 (see tricks to connect to Central).
>
> Benefits - more programmers can practice coding while improving our
> codebase.
>
> What's your opinion on the subject?
>
> https://maven.apache.org/resolver/
>
> Kind regards
> Sylwester
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
On 09.05.20 22:13, Sylwester Lachiewicz wrote:
> Hi to all,
>
> based on the previous vote to require Java 8 for Maven Core - I would like
> to propose setting the same minimum for Maven Resolver 2.0
>
> Maven Resolver is a base component to solve dependencies for Maven. It can
> also be used separately from Maven for other projects.
> Because Java 7 updates are no longer available, the market is also moving
> towards using the newer version of Java 8/11.
> Practically the Core requirement means that Resolver has little chance of
> being used in Java 7 (see tricks to connect to Central).
>
> Benefits - more programmers can practice coding while improving our
> codebase.
Clear +1 to move to JDK8 for Resolver.
Kind regards
Karl Heinz Marbaise
>
> What's your opinion on the subject?
>
> https://maven.apache.org/resolver/
>
> Kind regards
> Sylwester
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Enrico Olivelli <eo...@gmail.com>.
+1
Enrico
Il giorno sab 9 mag 2020 alle ore 22:19 Elliotte Rusty Harold <
elharo@ibiblio.org> ha scritto:
> It is not true that Java 7 updates are no longer available. Java 7
> updates are available from Oracle for paying customers and from other
> vendors such as Azul for everyone.
>
> My preference is not to move unless there's a clear reason to do so.
> Are there specific features in Java 8 that would be useful for Maven
> resolver? E.g. support for a new protocol that isn't available in Java
> 7 such as TLS 1.3?
>
>
> On Sat, May 9, 2020 at 4:13 PM Sylwester Lachiewicz
> <sl...@gmail.com> wrote:
> >
> > Hi to all,
> >
> > based on the previous vote to require Java 8 for Maven Core - I would
> like
> > to propose setting the same minimum for Maven Resolver 2.0
> >
> > Maven Resolver is a base component to solve dependencies for Maven. It
> can
> > also be used separately from Maven for other projects.
> > Because Java 7 updates are no longer available, the market is also moving
> > towards using the newer version of Java 8/11.
> > Practically the Core requirement means that Resolver has little chance of
> > being used in Java 7 (see tricks to connect to Central).
> >
> > Benefits - more programmers can practice coding while improving our
> > codebase.
> >
> > What's your opinion on the subject?
> >
> > https://maven.apache.org/resolver/
> >
> > Kind regards
> > Sylwester
>
>
>
> --
> Elliotte Rusty Harold
> elharo@ibiblio.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Sylwester Lachiewicz <sl...@gmail.com>.
Yes, we can use Path from NIO now, but if we have methods that return File
it will not work. - please check the last comments in MNG-6444.
Looks like pressure to keep Resoler at Java 7 level is high - I'll not
force that change. I hope after some time it will be more natural.
Thx for votes and arguments.
Sylwester
śr., 20 maj 2020 o 01:08 Elliotte Rusty Harold <el...@ibiblio.org>
napisał(a):
> On Tue, May 19, 2020 at 6:54 PM Sylwester Lachiewicz
> <sl...@gmail.com> wrote:
> >
> > Hi,
> > I would prefer to keep in sync a minimal version of Java version for
> Maven
> > Core and Resolver so we can use all goodies from Java 8 like mentioned
> > streams, default methods.
> > Real cases - https://jira.apache.org/jira/browse/MNG-6444 migrate code
> to
> > use NIO
>
> NIO is fully functional in Java 7, I think. Certainly you can use Path
> there.
>
> > Resolver is about to navigate through the graph - so maybe some parts
> will
> > look better, would be easier to understand or can be implemented in a
> more
> > efficient way?
>
> I'd be pleasantly surprised if this proves to be the case. I spend a
> **lot** of time in code reviews and refactoring fighting against
> incomprehensible lambdas. Maybe one time in ten, I find a lambda more
> readable than the alternative. I have **never** encountered a
> production use of lambdas that was more efficient than the
> alternative.
>
> --
> Elliotte Rusty Harold
> elharo@ibiblio.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Elliotte Rusty Harold <el...@ibiblio.org>.
On Tue, May 19, 2020 at 6:54 PM Sylwester Lachiewicz
<sl...@gmail.com> wrote:
>
> Hi,
> I would prefer to keep in sync a minimal version of Java version for Maven
> Core and Resolver so we can use all goodies from Java 8 like mentioned
> streams, default methods.
> Real cases - https://jira.apache.org/jira/browse/MNG-6444 migrate code to
> use NIO
NIO is fully functional in Java 7, I think. Certainly you can use Path there.
> Resolver is about to navigate through the graph - so maybe some parts will
> look better, would be easier to understand or can be implemented in a more
> efficient way?
I'd be pleasantly surprised if this proves to be the case. I spend a
**lot** of time in code reviews and refactoring fighting against
incomprehensible lambdas. Maybe one time in ten, I find a lambda more
readable than the alternative. I have **never** encountered a
production use of lambdas that was more efficient than the
alternative.
--
Elliotte Rusty Harold
elharo@ibiblio.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Sylwester Lachiewicz <sl...@gmail.com>.
Hi,
I would prefer to keep in sync a minimal version of Java version for Maven
Core and Resolver so we can use all goodies from Java 8 like mentioned
streams, default methods.
Real cases - https://jira.apache.org/jira/browse/MNG-6444 migrate code to
use NIO - also in many places we still have problems with concurrency,
locking.
Resolver is about to navigate through the graph - so maybe some parts will
look better, would be easier to understand or can be implemented in a more
efficient way?
it is tiring that using a newer version of Java every day, a potential
contributor would have to switch to Java 7 to improve something - it
definitely doesn't encourage new developers.
But yes, on opposite side - in resolve there are almost no new commits in
the last 2 years, and still many open PR not yet reviewed and merged.
Sylwester
sob., 9 maj 2020 o 22:19 Elliotte Rusty Harold <el...@ibiblio.org>
napisał(a):
> It is not true that Java 7 updates are no longer available. Java 7
> updates are available from Oracle for paying customers and from other
> vendors such as Azul for everyone.
>
> My preference is not to move unless there's a clear reason to do so.
> Are there specific features in Java 8 that would be useful for Maven
> resolver? E.g. support for a new protocol that isn't available in Java
> 7 such as TLS 1.3?
>
>
> On Sat, May 9, 2020 at 4:13 PM Sylwester Lachiewicz
> <sl...@gmail.com> wrote:
> >
> > Hi to all,
> >
> > based on the previous vote to require Java 8 for Maven Core - I would
> like
> > to propose setting the same minimum for Maven Resolver 2.0
> >
> > Maven Resolver is a base component to solve dependencies for Maven. It
> can
> > also be used separately from Maven for other projects.
> > Because Java 7 updates are no longer available, the market is also moving
> > towards using the newer version of Java 8/11.
> > Practically the Core requirement means that Resolver has little chance of
> > being used in Java 7 (see tricks to connect to Central).
> >
> > Benefits - more programmers can practice coding while improving our
> > codebase.
> >
> > What's your opinion on the subject?
> >
> > https://maven.apache.org/resolver/
> >
> > Kind regards
> > Sylwester
>
>
>
> --
> Elliotte Rusty Harold
> elharo@ibiblio.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Michael Osipov <mi...@apache.org>.
Strongly agree with Elliotte. Rather than rewriting existing, working
code, I'd rather see issues addressed.
M
Am 2020-05-09 um 22:19 schrieb Elliotte Rusty Harold:
> It is not true that Java 7 updates are no longer available. Java 7
> updates are available from Oracle for paying customers and from other
> vendors such as Azul for everyone.
>
> My preference is not to move unless there's a clear reason to do so.
> Are there specific features in Java 8 that would be useful for Maven
> resolver? E.g. support for a new protocol that isn't available in Java
> 7 such as TLS 1.3?
>
>
> On Sat, May 9, 2020 at 4:13 PM Sylwester Lachiewicz
> <sl...@gmail.com> wrote:
>>
>> Hi to all,
>>
>> based on the previous vote to require Java 8 for Maven Core - I would like
>> to propose setting the same minimum for Maven Resolver 2.0
>>
>> Maven Resolver is a base component to solve dependencies for Maven. It can
>> also be used separately from Maven for other projects.
>> Because Java 7 updates are no longer available, the market is also moving
>> towards using the newer version of Java 8/11.
>> Practically the Core requirement means that Resolver has little chance of
>> being used in Java 7 (see tricks to connect to Central).
>>
>> Benefits - more programmers can practice coding while improving our
>> codebase.
>>
>> What's your opinion on the subject?
>>
>> https://maven.apache.org/resolver/
>>
>> Kind regards
>> Sylwester
>
>
>
> --
> Elliotte Rusty Harold
> elharo@ibiblio.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Elliotte Rusty Harold <el...@ibiblio.org>.
It is not true that Java 7 updates are no longer available. Java 7
updates are available from Oracle for paying customers and from other
vendors such as Azul for everyone.
My preference is not to move unless there's a clear reason to do so.
Are there specific features in Java 8 that would be useful for Maven
resolver? E.g. support for a new protocol that isn't available in Java
7 such as TLS 1.3?
On Sat, May 9, 2020 at 4:13 PM Sylwester Lachiewicz
<sl...@gmail.com> wrote:
>
> Hi to all,
>
> based on the previous vote to require Java 8 for Maven Core - I would like
> to propose setting the same minimum for Maven Resolver 2.0
>
> Maven Resolver is a base component to solve dependencies for Maven. It can
> also be used separately from Maven for other projects.
> Because Java 7 updates are no longer available, the market is also moving
> towards using the newer version of Java 8/11.
> Practically the Core requirement means that Resolver has little chance of
> being used in Java 7 (see tricks to connect to Central).
>
> Benefits - more programmers can practice coding while improving our
> codebase.
>
> What's your opinion on the subject?
>
> https://maven.apache.org/resolver/
>
> Kind regards
> Sylwester
--
Elliotte Rusty Harold
elharo@ibiblio.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Sylwester Lachiewicz <sl...@gmail.com>.
For now, I can think only about movie code to Java 8 syntax (but yes, we
still have lots of code that can be upgraded to level 5 and 7...)
then maybe small refactoring just to have cleaner code.
I would be best if we can have Java 8 Resolver + Wagon released before
Maven 3.7 - but also nothing wrong will happen if we stay with the current
version of Resolver.
S.
pon., 11 maj 2020 o 16:29 Tibor Digana <ti...@apache.org> napisał(a):
> The code written in j8 looks more compact. The loops and annonymous classes
> with one method do not waste the code lines.
>
> You can create a branch for the Maven Resolver 2.0 and the later Maven can
> use it.
>
> Do we need to have Maven Resolver 2.0 in the Maven 3.7.0?
> The Maven 3.7.0 is @j8 and using Resolver 1.4.2.
> What changes you expect in Maven Resolver 2.0? If it is only Java 1.8 *code
> *then it should be no problem except the performance of some Streams.
>
> Probably the Maven Resolver 2.0 would be used in 3.7.1 or 3.8.0. But if the
> Maven 3.7.0 is @j8 then using Resolver 2.0@j8 should not harm the Maven.
> The older versions of Resolver can continue the development in branches.
> Everything would have a permanent progress and we don't have to stop
> somewhere in the master.
>
>
> On Sat, May 9, 2020 at 10:13 PM Sylwester Lachiewicz <
> slachiewicz@gmail.com>
> wrote:
>
> > Hi to all,
> >
> > based on the previous vote to require Java 8 for Maven Core - I would
> like
> > to propose setting the same minimum for Maven Resolver 2.0
> >
> > Maven Resolver is a base component to solve dependencies for Maven. It
> can
> > also be used separately from Maven for other projects.
> > Because Java 7 updates are no longer available, the market is also moving
> > towards using the newer version of Java 8/11.
> > Practically the Core requirement means that Resolver has little chance of
> > being used in Java 7 (see tricks to connect to Central).
> >
> > Benefits - more programmers can practice coding while improving our
> > codebase.
> >
> > What's your opinion on the subject?
> >
> > https://maven.apache.org/resolver/
> >
> > Kind regards
> > Sylwester
> >
>
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Tibor Digana <ti...@apache.org>.
The code written in j8 looks more compact. The loops and annonymous classes
with one method do not waste the code lines.
You can create a branch for the Maven Resolver 2.0 and the later Maven can
use it.
Do we need to have Maven Resolver 2.0 in the Maven 3.7.0?
The Maven 3.7.0 is @j8 and using Resolver 1.4.2.
What changes you expect in Maven Resolver 2.0? If it is only Java 1.8 *code
*then it should be no problem except the performance of some Streams.
Probably the Maven Resolver 2.0 would be used in 3.7.1 or 3.8.0. But if the
Maven 3.7.0 is @j8 then using Resolver 2.0@j8 should not harm the Maven.
The older versions of Resolver can continue the development in branches.
Everything would have a permanent progress and we don't have to stop
somewhere in the master.
On Sat, May 9, 2020 at 10:13 PM Sylwester Lachiewicz <sl...@gmail.com>
wrote:
> Hi to all,
>
> based on the previous vote to require Java 8 for Maven Core - I would like
> to propose setting the same minimum for Maven Resolver 2.0
>
> Maven Resolver is a base component to solve dependencies for Maven. It can
> also be used separately from Maven for other projects.
> Because Java 7 updates are no longer available, the market is also moving
> towards using the newer version of Java 8/11.
> Practically the Core requirement means that Resolver has little chance of
> being used in Java 7 (see tricks to connect to Central).
>
> Benefits - more programmers can practice coding while improving our
> codebase.
>
> What's your opinion on the subject?
>
> https://maven.apache.org/resolver/
>
> Kind regards
> Sylwester
>
Re: JDK 8 Minimum Requirement for Maven Resolver 2.0
Posted by Gary Gregory <ga...@gmail.com>.
+1 non-binding.
On Sat, May 9, 2020, 16:13 Sylwester Lachiewicz <sl...@gmail.com>
wrote:
> Hi to all,
>
> based on the previous vote to require Java 8 for Maven Core - I would like
> to propose setting the same minimum for Maven Resolver 2.0
>
> Maven Resolver is a base component to solve dependencies for Maven. It can
> also be used separately from Maven for other projects.
> Because Java 7 updates are no longer available, the market is also moving
> towards using the newer version of Java 8/11.
> Practically the Core requirement means that Resolver has little chance of
> being used in Java 7 (see tricks to connect to Central).
>
> Benefits - more programmers can practice coding while improving our
> codebase.
>
> What's your opinion on the subject?
>
> https://maven.apache.org/resolver/
>
> Kind regards
> Sylwester
>