[GitHub] [airflow] kaxil commented on a change in pull request #18310: Fix mini scheduler not respecting `wait_for_downstream` dependency

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #18310:
URL: https://github.com/apache/airflow/pull/18310#discussion_r710956225



##########
File path: airflow/jobs/local_task_job.py
##########
@@ -226,6 +226,18 @@ def heartbeat_callback(self, session=None):
     @Sentry.enrich_errors
     def _run_mini_scheduler_on_child_tasks(self, session=None) -> None:
         try:
+
+            if (
+                self.task_instance.task.wait_for_downstream
+                and self.task_instance.get_previous_ti()
+                and not self.task_instance.are_dependents_done()
+            ):
+                self.log.info(
+                    "No downstream tasks scheduled because task instance "
+                    "dependents are still running and wait_for_downstream is true"

Review comment:
       ```suggestion
                       "dependents have not completed yet and wait_for_downstream is true"
   ```
   
   as the task can be in queued or scheduled state too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org