You are viewing a plain text version of this content. The canonical link for it is here.
Posted to muse-dev@ws.apache.org by "Joel Hawkins (JIRA)" <ji...@apache.org> on 2007/03/13 14:28:11 UTC

[jira] Created: (MUSE-204) SimpleMetric implementation for IntervalMetric improperly validates null check on duration string

SimpleMetric implementation for IntervalMetric improperly validates null check on duration string
-------------------------------------------------------------------------------------------------

                 Key: MUSE-204
                 URL: https://issues.apache.org/jira/browse/MUSE-204
             Project: Muse
          Issue Type: Bug
          Components: WSDM MUWS Metrics
    Affects Versions: 2.1.0
         Environment: All
            Reporter: Joel Hawkins
         Assigned To: Joel Hawkins
             Fix For: 2.2.0


        //
        // sanity check: if it's an Interval, it needs... an interval!
        //
        if (isInterval() != (getIntervalString() != null))
        {
            Object[] filler = { name };
            throw new RuntimeException(_MESSAGES.get("InvalidIntervalDef", filler));
        }

should be

        //
        // sanity check: if it's an Interval, it needs... an interval!
        //
        if (isInterval() && (getIntervalString() == null))
        {
            Object[] filler = { name };
            throw new RuntimeException(_MESSAGES.get("InvalidIntervalDef", filler));
        }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Closed: (MUSE-204) SimpleMetric implementation for IntervalMetric improperly validates null check on duration string

Posted by "Dan Jemiolo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MUSE-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Jemiolo closed MUSE-204.
----------------------------

    Resolution: Fixed

Submitted your fix.

> SimpleMetric implementation for IntervalMetric improperly validates null check on duration string
> -------------------------------------------------------------------------------------------------
>
>                 Key: MUSE-204
>                 URL: https://issues.apache.org/jira/browse/MUSE-204
>             Project: Muse
>          Issue Type: Bug
>          Components: WSDM MUWS Metrics
>    Affects Versions: 2.1.0
>         Environment: All
>            Reporter: Joel Hawkins
>         Assigned To: Joel Hawkins
>             Fix For: 2.2.0
>
>
>         //
>         // sanity check: if it's an Interval, it needs... an interval!
>         //
>         if (isInterval() != (getIntervalString() != null))
>         {
>             Object[] filler = { name };
>             throw new RuntimeException(_MESSAGES.get("InvalidIntervalDef", filler));
>         }
> should be
>         //
>         // sanity check: if it's an Interval, it needs... an interval!
>         //
>         if (isInterval() && (getIntervalString() == null))
>         {
>             Object[] filler = { name };
>             throw new RuntimeException(_MESSAGES.get("InvalidIntervalDef", filler));
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org