You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2022/01/05 13:45:38 UTC
[GitHub] [groovy] paulk-asert commented on a change in pull request #1670: GROOVY-5169, GROOVY-7682: JSON output: serialization fixes
paulk-asert commented on a change in pull request #1670:
URL: https://github.com/apache/groovy/pull/1670#discussion_r778828461
##########
File path: subprojects/groovy-json/build.gradle
##########
@@ -21,13 +21,19 @@ plugins {
}
dependencies {
- api rootProject // JsonBuilder extends GroovyObjectSupport...
Review comment:
I think it is useful to keep the comment, otherwise it is hard to track down why we use `api` here and not `implementation`. We should have a similar comment for each api dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org