[GitHub] [netbeans] matthiasblaesing commented on pull request #4357: nb project wizard fixes

[GitBox <gi...@apache.org>]

matthiasblaesing commented on PR #4357:
URL: https://github.com/apache/netbeans/pull/4357#issuecomment-1179781661

   According to the documentation of the nbm-maven plugin this comment is wrong:
   
   https://github.com/apache/netbeans/blob/0b2627f571c030566472b40309c3f7ff409c8db1/apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardPanelVisual.java#L274
   
   Looking at the history I read it, that the option should have been disabled for versions before NetBeans 6.9
   
   https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/blob/153cbd6dbbee835833fbffaa349054c2314e8249/nbm-maven-plugin/src/site/apt/index.apt.vm#L126-L145
   
   and thus we should default to enable OSGI support.
   
   This would also make more sense as the NetBeans support for OSGI improved and did not regress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists