You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by sammcveety <gi...@git.apache.org> on 2016/09/22 16:55:17 UTC

[GitHub] incubator-beam pull request #988: Add initial scaffolding for default bucket

GitHub user sammcveety opened a pull request:

    https://github.com/apache/incubator-beam/pull/988

    Add initial scaffolding for default bucket

    @tgroh, could you please take a look?
    
    Before reviewing further, I was hoping to get clarity on whether the travis failures I'm seeing are related to this PR:
    
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/testing/AutoValue_TestStream_ElementEvent.java:[8,7] duplicate class: org.apache.beam.sdk.testing.AutoValue_TestStream_ElementEvent
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/testing/AutoValue_TestStream_WatermarkEvent.java:[8,7] duplicate class: org.apache.beam.sdk.testing.AutoValue_TestStream_WatermarkEvent
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/testing/AutoValue_TestStream_ProcessingTimeEvent.java:[8,7] duplicate class: org.apache.beam.sdk.testing.AutoValue_TestStream_ProcessingTimeEvent
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/display/AutoValue_DisplayData_Item.java:[7,7] duplicate class: org.apache.beam.sdk.transforms.display.AutoValue_DisplayData_Item
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/options/AutoValue_PipelineOptionSpec.java:[8,7] duplicate class: org.apache.beam.sdk.options.AutoValue_PipelineOptionSpec
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/options/AutoValue_ProxyInvocationHandler_BoundValue.java:[7,7] duplicate class: org.apache.beam.sdk.options.AutoValue_ProxyInvocationHandler_BoundValue
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/reflect/AutoValue_DoFnSignature.java:[8,7] duplicate class: org.apache.beam.sdk.transforms.reflect.AutoValue_DoFnSignature
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/reflect/AutoValue_DoFnSignature_ProcessElementMethod.java:[9,7] duplicate class: org.apache.beam.sdk.transforms.reflect.AutoValue_DoFnSignature_ProcessElementMethod
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/reflect/AutoValue_DoFnSignature_BundleMethod.java:[8,7] duplicate class: org.apache.beam.sdk.transforms.reflect.AutoValue_DoFnSignature_BundleMethod
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/reflect/AutoValue_DoFnSignature_LifecycleMethod.java:[8,7] duplicate class: org.apache.beam.sdk.transforms.reflect.AutoValue_DoFnSignature_LifecycleMethod
    
    - Provide a hook for determining the project number associated with a bucket
    - Provide an API for looking up the project number from a project ID

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sammcveety/incubator-beam sgmc/default_bucket

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/988.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #988
    
----
commit bb87b3a735e87eac3105f15294c4e2e782ae1870
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T01:19:53Z

    Add initial bucket stuff.

commit f6b4616d9f19b5f484bf573a36c90d075a155cb7
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T01:45:39Z

    Basic CRM client.

commit b7e93be0501cf26092456c757fdf7affa71cdd2f
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:08:05Z

    Fix some compilation errors and update pom.

commit 4077ef3d7b9d906dbfbb4c4189fde1ac81a0e8f9
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:22:48Z

    Minor updates.

commit dab7ec2f6aaf19dc5cf382b926bd1766861d8127
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:36:38Z

    Add options.

commit 0ab2a1f11364b0db707eccaeaa7342479b24a594
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:39:35Z

    Fix more things.

commit b005d0f80c73c1dca78d64f057731e4bd91420cf
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T03:04:40Z

    Actually include file.

commit a5a616a74b33074ce22d26efc12d3b19867f8d7b
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T03:17:26Z

    Checkstyle fixes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #988: Add initial scaffolding for default bucket

Posted by sammcveety <gi...@git.apache.org>.
Github user sammcveety closed the pull request at:

    https://github.com/apache/incubator-beam/pull/988


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #988: Add initial scaffolding for default bucket

Posted by sammcveety <gi...@git.apache.org>.
GitHub user sammcveety reopened a pull request:

    https://github.com/apache/incubator-beam/pull/988

    Add initial scaffolding for default bucket

    @tgroh, could you please take a look?
    
    Before reviewing further, I was hoping to get clarity on whether the travis failures I'm seeing are related to this PR:
    
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/testing/AutoValue_TestStream_ElementEvent.java:[8,7] duplicate class: org.apache.beam.sdk.testing.AutoValue_TestStream_ElementEvent
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/testing/AutoValue_TestStream_WatermarkEvent.java:[8,7] duplicate class: org.apache.beam.sdk.testing.AutoValue_TestStream_WatermarkEvent
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/testing/AutoValue_TestStream_ProcessingTimeEvent.java:[8,7] duplicate class: org.apache.beam.sdk.testing.AutoValue_TestStream_ProcessingTimeEvent
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/display/AutoValue_DisplayData_Item.java:[7,7] duplicate class: org.apache.beam.sdk.transforms.display.AutoValue_DisplayData_Item
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/options/AutoValue_PipelineOptionSpec.java:[8,7] duplicate class: org.apache.beam.sdk.options.AutoValue_PipelineOptionSpec
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/options/AutoValue_ProxyInvocationHandler_BoundValue.java:[7,7] duplicate class: org.apache.beam.sdk.options.AutoValue_ProxyInvocationHandler_BoundValue
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/reflect/AutoValue_DoFnSignature.java:[8,7] duplicate class: org.apache.beam.sdk.transforms.reflect.AutoValue_DoFnSignature
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/reflect/AutoValue_DoFnSignature_ProcessElementMethod.java:[9,7] duplicate class: org.apache.beam.sdk.transforms.reflect.AutoValue_DoFnSignature_ProcessElementMethod
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/reflect/AutoValue_DoFnSignature_BundleMethod.java:[8,7] duplicate class: org.apache.beam.sdk.transforms.reflect.AutoValue_DoFnSignature_BundleMethod
    [ERROR] /Users/travis/build/sammcveety/incubator-beam/sdks/java/core/target/generated-sources/annotations/org/apache/beam/sdk/transforms/reflect/AutoValue_DoFnSignature_LifecycleMethod.java:[8,7] duplicate class: org.apache.beam.sdk.transforms.reflect.AutoValue_DoFnSignature_LifecycleMethod
    
    - Provide a hook for determining the project number associated with a bucket
    - Provide an API for looking up the project number from a project ID

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sammcveety/incubator-beam sgmc/default_bucket

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/988.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #988
    
----
commit bb87b3a735e87eac3105f15294c4e2e782ae1870
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T01:19:53Z

    Add initial bucket stuff.

commit f6b4616d9f19b5f484bf573a36c90d075a155cb7
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T01:45:39Z

    Basic CRM client.

commit b7e93be0501cf26092456c757fdf7affa71cdd2f
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:08:05Z

    Fix some compilation errors and update pom.

commit 4077ef3d7b9d906dbfbb4c4189fde1ac81a0e8f9
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:22:48Z

    Minor updates.

commit dab7ec2f6aaf19dc5cf382b926bd1766861d8127
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:36:38Z

    Add options.

commit 0ab2a1f11364b0db707eccaeaa7342479b24a594
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:39:35Z

    Fix more things.

commit b005d0f80c73c1dca78d64f057731e4bd91420cf
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T03:04:40Z

    Actually include file.

commit a5a616a74b33074ce22d26efc12d3b19867f8d7b
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T03:17:26Z

    Checkstyle fixes.

commit 287061b75ddaf6908dc14726876059443083f62c
Author: Pei He <pe...@google.com>
Date:   2016-09-22T02:56:01Z

    Support BigQuery DATE type

commit 8245f9b4b2ec28ad76c2cf0813b3a2de28aaebcd
Author: Luke Cwik <lc...@google.com>
Date:   2016-09-22T21:27:43Z

    Support BigQuery DATE type
    
    This closes #985

commit f93ca9ce803a8847a7178ff0d7c5e1631bed8f2d
Author: Luke Cwik <lc...@google.com>
Date:   2016-09-22T00:11:22Z

    Update grpc to 1.0.1 and protobuf to 3.0.0

commit a447d130172ec7c270fc9f1d16a2f7404898461e
Author: Luke Cwik <lc...@google.com>
Date:   2016-09-22T02:49:10Z

    Update PubsubGrpcClient to not take in mocks as they are not needed anymore
    Update PubsubGrpcClientTest to use an inprocess server to handle requests/responses for testing.
    Add/remove required dependencies found missing by dep-analyzer plugin during upgrade to protobuf 3.0.0 and grpc 1.0.1

commit 4872bde8f4ad2655074c262b30373c9cd53ae103
Author: Luke Cwik <lc...@google.com>
Date:   2016-09-22T21:37:32Z

    Update grpc to 1.0.1 and protobuf to 3.0.0
    
    This closes #986

commit cccc58489bc8cbe4d702ff9ae07f932fb96141a1
Author: Sela <an...@paypal.com>
Date:   2016-09-21T12:13:02Z

    [BEAM-657] Support Read.Bounded primitive.
    
    Support Read.Bounded primitive.
    
    Avro requires this for snappy.
    
    Create is supported by Read.Bounded now.
    
    Read.Bounded support should solve gs issues now.
    
    remove unused direct translations. Addressed by BEAM-668.
    
    Assert deault parallelism, close reader on exception, and other improvements.
    
    Adressed more comments.
    
    Extra line.

commit a00d2f810992c450c14eab2bb5e3aa3ad3f80f74
Author: Sela <an...@paypal.com>
Date:   2016-09-22T22:32:26Z

    This closes #983

commit 22815474330cfb2123e1753245edb64faa315355
Author: Luke Cwik <lc...@google.com>
Date:   2016-09-23T16:08:33Z

    Minor clean-up of RunnableOnService definition

commit 2b8b20ded545bbb4fcbf3f196c6b965aa5e158ae
Author: Luke Cwik <lc...@google.com>
Date:   2016-09-23T16:19:37Z

    Minor clean-up of RunnableOnService definition
    
    This closes #993

commit 9a7f10605bdc6cd635b0475b383914acdcd94575
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-23T22:03:10Z

    Address many comments, add some tests.

commit b0588d9cfb6c5cb2d7951cc09556eca6f66487fe
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-23T22:12:07Z

    Finish testing work.

commit d61496589939af2cfead0f053e9e4af930d7e164
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-23T22:29:59Z

    Add more tests.

commit 3a3ebc8485e82ea0cef84e5c4b3a7f076b0a8ea4
Author: Pei He <pe...@google.com>
Date:   2016-09-23T23:11:24Z

    Update BigQueryIO tests who expect failure to be NeedsRunner tests

commit 3fe3bc8eb740123e4bbd5e9308b5294b14f4350b
Author: Luke Cwik <lc...@google.com>
Date:   2016-09-23T23:46:46Z

    In BigQueryIOTest, changes tests who expect failure to be NeedsRunner tests
    
    This closes #995

commit 8b07be20b9a505428419d05f062f6f87a2ecaeea
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-23T23:48:03Z

    Fix compilation errors.

commit 0c3a3cd8a018bdfdffe32d57632bf305a7252eab
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-24T00:20:24Z

    Fix more tests.

commit e00e0911b335e150dbedbfde7309f28edcae5417
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-24T00:26:06Z

    Actually check project number in test.

commit 3c5c63ea52390db08c9eef90cb8ff97947d30964
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-24T04:57:44Z

    Switch API to use Bucket instead of narrower parameters.

commit 02f4c726359630da46b0159a7fc49056b21ab84c
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T01:19:53Z

    Add initial bucket stuff.

commit 95e99a911bd3d57f2d471fc5c6497ea3b99f4700
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T01:45:39Z

    Basic CRM client.

commit 7dcae41501abdb456a8e94a250810c16710ad412
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:08:05Z

    Fix some compilation errors and update pom.

commit cb77c8bcc5379cdbab055a7be25be7905f120552
Author: sammcveety <sa...@gmail.com>
Date:   2016-09-18T02:22:48Z

    Minor updates.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #988: Add initial scaffolding for default bucket

Posted by sammcveety <gi...@git.apache.org>.
Github user sammcveety closed the pull request at:

    https://github.com/apache/incubator-beam/pull/988


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---