You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/01/11 18:41:53 UTC
[GitHub] [avro] martin-g opened a new pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
martin-g opened a new pull request #1454:
URL: https://github.com/apache/avro/pull/1454
- Disable Spotless' removeUnusedImports
(https://github.com/diffplug/spotless/issues/834). It will be re-enabled
once Avro is updated to JDK 11+. Then we can add .mvn/jvm.config (see
https://github.com/diffplug/spotless/issues/834#issuecomment-817524058)
- Replace Easymock with Mockito.
### Jira
- [X] My PR addresses the following [AVRO-3120](https://issues.apache.org/jira/browse/AVRO-3120) issue
-
### Tests
- [X] My PR updates several unit tests to use Mockito instead of Easymock
### Commits
- [X] My commits all reference Jira issues in their subject lines.
### Documentation
- [] TODO: Probably I should update the website and/or README
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1454:
URL: https://github.com/apache/avro/pull/1454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1454:
URL: https://github.com/apache/avro/pull/1454#issuecomment-1010687577
This PR fixes https://issues.apache.org/jira/browse/AVRO-3122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1454:
URL: https://github.com/apache/avro/pull/1454#issuecomment-1012054424
This PR changed only test related code, so I don't see a reason to backport it to branch-1.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1454:
URL: https://github.com/apache/avro/pull/1454#issuecomment-1012831437
Right! It looks safe to say this! :-)
But don't mention JDK 18/19 EAs yet!
Here we still have few problems:
```
[ERROR] Failures:
[ERROR] TestSpecificCompiler.testInvalidParameterCounts:212->assertCompilesWithJavaCompiler:86->assertCompilesWithJavaCompiler:129 Warnings produced when compiling generated code with -Xlint:all expected:<0> but was:<100>
[ERROR] TestSpecificCompiler.testLogicalTypesWithMultipleFieldsDateTime:746->assertCompilesWithJavaCompiler:86->assertCompilesWithJavaCompiler:129 Warnings produced when compiling generated code with -Xlint:all expected:<0> but was:<3>
[ERROR] TestSpecificCompiler.testMaxValidParameterCounts:200->assertCompilesWithJavaCompiler:86->assertCompilesWithJavaCompiler:129 Warnings produced when compiling generated code with -Xlint:all expected:<0> but was:<100>
[ERROR] TestSpecificCompiler.testUnionAndFixedFields:738->assertCompilesWithJavaCompiler:86->assertCompilesWithJavaCompiler:129 Warnings produced when compiling generated code with -Xlint:all expected:<0> but was:<2>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1454:
URL: https://github.com/apache/avro/pull/1454#issuecomment-1013478448
Cherry-picked the changes to `branch-1.11`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1454:
URL: https://github.com/apache/avro/pull/1454#issuecomment-1012844937
About JDK 18+: https://github.com/apache/avro/pull/1459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia commented on pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #1454:
URL: https://github.com/apache/avro/pull/1454#issuecomment-1012833808
I think we should cherry pick it, for 1.11.1 because it is safe enough, and also to avoid eventual cherry pick conflicts. WDYT? Would you mind to open a cherry pick PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on a change in pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #1454:
URL: https://github.com/apache/avro/pull/1454#discussion_r782431581
##########
File path: lang/java/pom.xml
##########
@@ -289,9 +289,10 @@
<!-- Avro uses Sun's java code style conventions with 2 spaces, this is a modified version of
the eclipse formatter -->
<file>${main.basedir}/lang/java/eclipse-java-formatter.xml</file>
- <version>4.19.0</version>
+ <version>4.21.0</version>
</eclipse>
- <removeUnusedImports/>
+ <!-- Temporarily disabled for JDK 16+ builds -->
+ <!--<removeUnusedImports/>-->
Review comment:
I hope we can leave with this being disabled until we update Avro to JDK 11. Then we can add the needed `--add-exports ...` for Spotless Maven plugin in `.mvn/jvm.config`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1454:
URL: https://github.com/apache/avro/pull/1454#issuecomment-1012844842
Do we need a PR for cherry-picks ? I'd just cherry-pick it and update `fixVersion` in JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia commented on pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #1454:
URL: https://github.com/apache/avro/pull/1454#issuecomment-1012561357
Nice, well done @martin-g ! I wonder if we can argueable say then that Avro 1.11.0 was already Java 17 compatible, we were just not testing it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1454: AVRO-3120: Support Next Java LTS (Java 17)
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1454:
URL: https://github.com/apache/avro/pull/1454#issuecomment-1015374328
> Do we need a PR for cherry-picks ? I'd just cherry-pick it and update `fixVersion` in JIRA.
Hey -- I would only create a PR for a cherry-pick if there was a good reason (an unexpected merge-conflict, a potential break or doubt, or anything that might need extra eyes).
Thanks for this update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org