You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/04/01 16:14:16 UTC
Re: Review Request 45039: Updated the comment for launching tasks and
accepting offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/
-----------------------------------------------------------
(Updated April 1, 2016, 2:14 p.m.)
Review request for mesos, Ben Mahler and Neil Conway.
Repository: mesos
Description
-------
If the task does not pass validation,
its resources are considered declined.
Diffs
-----
docs/app-framework-development-guide.md 1d8bebde67f69fd414509b8861571137d3569b46
include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
src/java/src/org/apache/mesos/SchedulerDriver.java bf866f5ebece2505eaa27bf39a1382cd1a2a069a
src/python/interface/src/mesos/interface/__init__.py 232890daa6d222ae1c86906bbc484c8e635c4eb7
Diff: https://reviews.apache.org/r/45039/diff/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 45039: Updated the comment for launching tasks and
accepting offers.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review126586
-----------------------------------------------------------
docs/app-framework-development-guide.md (line 184)
<https://reviews.apache.org/r/45039/#comment189599>
Here and below, I would personally rephrase this slightly.
"Any remaining resources remaining (i.e., those that are not used by the launched tasks or their executors) will be considered unused. Note that this includes resources used by tasks that the framework attempted to launch but failed (with TASK_ERROR) due to a malformed task description."
- Neil Conway
On April 1, 2016, 2:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 2:14 p.m.)
>
>
> Review request for mesos, Ben Mahler and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task does not pass validation,
> its resources are considered declined.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 1d8bebde67f69fd414509b8861571137d3569b46
> include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
> src/java/src/org/apache/mesos/SchedulerDriver.java bf866f5ebece2505eaa27bf39a1382cd1a2a069a
> src/python/interface/src/mesos/interface/__init__.py 232890daa6d222ae1c86906bbc484c8e635c4eb7
>
> Diff: https://reviews.apache.org/r/45039/diff/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 45039: Updated the comment for launching tasks and
accepting offers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review126588
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45039]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 1, 2016, 2:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 2:14 p.m.)
>
>
> Review request for mesos, Ben Mahler and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task does not pass validation,
> its resources are considered declined.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 1d8bebde67f69fd414509b8861571137d3569b46
> include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
> src/java/src/org/apache/mesos/SchedulerDriver.java bf866f5ebece2505eaa27bf39a1382cd1a2a069a
> src/python/interface/src/mesos/interface/__init__.py 232890daa6d222ae1c86906bbc484c8e635c4eb7
>
> Diff: https://reviews.apache.org/r/45039/diff/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 45039: Updated the comment for launching tasks and
accepting offers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review127115
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45039]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 5, 2016, 1:27 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 1:27 p.m.)
>
>
> Review request for mesos, Ben Mahler and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task does not pass validation,
> its resources are considered declined.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 1d8bebde67f69fd414509b8861571137d3569b46
> include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
> src/java/src/org/apache/mesos/SchedulerDriver.java bf866f5ebece2505eaa27bf39a1382cd1a2a069a
> src/python/interface/src/mesos/interface/__init__.py 232890daa6d222ae1c86906bbc484c8e635c4eb7
>
> Diff: https://reviews.apache.org/r/45039/diff/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 45039: Updated the comment for launching tasks and
accepting offers.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review127091
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On April 5, 2016, 1:27 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 1:27 p.m.)
>
>
> Review request for mesos, Ben Mahler and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task does not pass validation,
> its resources are considered declined.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 1d8bebde67f69fd414509b8861571137d3569b46
> include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
> src/java/src/org/apache/mesos/SchedulerDriver.java bf866f5ebece2505eaa27bf39a1382cd1a2a069a
> src/python/interface/src/mesos/interface/__init__.py 232890daa6d222ae1c86906bbc484c8e635c4eb7
>
> Diff: https://reviews.apache.org/r/45039/diff/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 45039: Updated the comment for launching tasks and
accepting offers.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review127092
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On April 5, 2016, 6:27 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 6:27 a.m.)
>
>
> Review request for mesos, Ben Mahler and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the task does not pass validation,
> its resources are considered declined.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 1d8bebde67f69fd414509b8861571137d3569b46
> include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
> src/java/src/org/apache/mesos/SchedulerDriver.java bf866f5ebece2505eaa27bf39a1382cd1a2a069a
> src/python/interface/src/mesos/interface/__init__.py 232890daa6d222ae1c86906bbc484c8e635c4eb7
>
> Diff: https://reviews.apache.org/r/45039/diff/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 45039: Updated the comment for launching tasks and
accepting offers.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/
-----------------------------------------------------------
(Updated April 5, 2016, 1:27 p.m.)
Review request for mesos, Ben Mahler and Neil Conway.
Repository: mesos
Description
-------
If the task does not pass validation,
its resources are considered declined.
Diffs (updated)
-----
docs/app-framework-development-guide.md 1d8bebde67f69fd414509b8861571137d3569b46
include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
src/java/src/org/apache/mesos/SchedulerDriver.java bf866f5ebece2505eaa27bf39a1382cd1a2a069a
src/python/interface/src/mesos/interface/__init__.py 232890daa6d222ae1c86906bbc484c8e635c4eb7
Diff: https://reviews.apache.org/r/45039/diff/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov