You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "eric-milles (via GitHub)" <gi...@apache.org> on 2025/04/18 19:17:56 UTC
[PR] GROOVY-11624: SC: post-`ResolveVisitor`, pre-`Verifier` constant inlining [groovy]
eric-milles opened a new pull request, #2200:
URL: https://github.com/apache/groovy/pull/2200
In case of references to external constants, `StaticCompilationVisitor` could replace constant arithmetic with methods calls before `Verifier` has a chance to fully inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-11624: SC: post-`ResolveVisitor`, pre-`Verifier` constant inlining [groovy]
Posted by "eric-milles (via GitHub)" <gi...@apache.org>.
eric-milles merged PR #2200:
URL: https://github.com/apache/groovy/pull/2200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-11624: SC: post-`ResolveVisitor`, pre-`Verifier` constant inlining [groovy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2200:
URL: https://github.com/apache/groovy/pull/2200#issuecomment-2816090478
## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2200?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 68.9452%. Comparing base [(`54fff88`)](https://app.codecov.io/gh/apache/groovy/commit/54fff885ce17cb551fc66ef5ae562ecf4513db45?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0a7dbd4`)](https://app.codecov.io/gh/apache/groovy/commit/0a7dbd4e4fac4e085a15178ae45e67219c15b66c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2200 +/- ##
==================================================
- Coverage 68.9476% 68.9452% -0.0024%
- Complexity 29552 29560 +8
==================================================
Files 1423 1423
Lines 113901 113905 +4
Branches 19753 19753
==================================================
Hits 78532 78532
- Misses 28770 28775 +5
+ Partials 6599 6598 -1
```
| [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2200?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../sc/transformers/StaticCompilationTransformer.java](https://app.codecov.io/gh/apache/groovy/pull/2200?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fsc%2Ftransformers%2FStaticCompilationTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zYy90cmFuc2Zvcm1lcnMvU3RhdGljQ29tcGlsYXRpb25UcmFuc2Zvcm1lci5qYXZh) | `98.5294% <100.0000%> (+0.0919%)` | :arrow_up: |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2200/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org