You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "wangkezun (GitHub)" <gi...@apache.org> on 2019/10/29 08:34:14 UTC

[GitHub] [dubbo] wangkezun commented on issue #5243: QUESTION Why NOT clear after log full?

In #writeLogToFile(), call processWithServiceLogger(logSet) or processWithAccessKeyLogger(logSet, file); will remove logged data.You can see here
https://github.com/apache/dubbo/blob/15d808446d4bebc3b87f986ccc657f9e5baff728/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java#L155
and here
https://github.com/apache/dubbo/blob/15d808446d4bebc3b87f986ccc657f9e5baff728/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java#L178

But there is still a TODO indicate that when log insertion rate is faster than writeToFile rate, the log would be simply ignored.
I will try to create a pr to fix this TODO.


[ Full content available at: https://github.com/apache/dubbo/issues/5243 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org