[GitHub] [beam] ibzib commented on a change in pull request #15081: [BEAM-12503] Process Support for ExternalWorkerService

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #15081:
URL: https://github.com/apache/beam/pull/15081#discussion_r661857627



##########
File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -79,13 +79,16 @@
 
   private static final String dockerContainerImageOption = "docker_container_image";
   private static final String externalServiceAddressOption = "external_service_address";
+  private static final String externalServiceExecutableOption = "external_service_executable";

Review comment:
       External workers should be completely decoupled from the runner. If we introduce `external_service_executable` as a pipeline option, we have to add it to the contract between the runner and the worker.
   
   The configuration of the workers should be left to the worker pool wherever possible. So instead of a pipeline option, we'd add command line arguments in the worker pool's main method. WDYT?

##########
File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -79,13 +79,16 @@
 
   private static final String dockerContainerImageOption = "docker_container_image";
   private static final String externalServiceAddressOption = "external_service_address";
+  private static final String externalServiceExecutableOption = "external_service_executable";

Review comment:
       What is the executable expected to be? What benefit is there to allowing an arbitrary executable? We may want to simplify things for the user by making this a boolean (processes/threads) with a fixed executable otherwise.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org