[jira] [Commented] (DATAFU-25) AliasableEvalFunc should use getInputSchema

["Matthew Hayes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DATAFU-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607079#comment-15607079 ] 

Matthew Hayes commented on DATAFU-25:
-------------------------------------

+1, this looks like a reasonable implementation to me.  Thanks for fixing this!  So basically we only fall back to the UDF context if the input schema isn't available via {{getInputSchema}} for whatever reason.  It's probably worth adding a comment explaining why we are checking both (i.e. that this method was implemented before Pig had getInputSchema and now we can rely on that if it is available).

Do you think there is any reason to keep the code that sets the input schema in the UDF context?  It doesn't seem to hurt, but I suppose it's extra code we probably don't need.

> AliasableEvalFunc should use getInputSchema
> -------------------------------------------
>
>                 Key: DATAFU-25
>                 URL: https://issues.apache.org/jira/browse/DATAFU-25
>             Project: DataFu
>          Issue Type: Improvement
>            Reporter: Matthew Hayes
>            Assignee: Eyal Allweil
>         Attachments: DATAFU-25.patch
>
>
> AliasableEvalFunc derives from ContextualEvalFunc and stores a map of aliases in the UDF context.  We can instead use getInputSchema, which was added to Pig 0.11.  This may in the process resolve DATAFU-6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)