[GitHub] [iceberg] danielcweeks commented on a diff in pull request #7519: Add REST support for SigV4 signed requests

["danielcweeks (via GitHub)" <gi...@apache.org>]

danielcweeks commented on code in PR #7519:
URL: https://github.com/apache/iceberg/pull/7519#discussion_r1184412384


##########
python/pyiceberg/catalog/rest.py:
##########
@@ -172,8 +175,6 @@ class OAuthErrorResponse(IcebergBaseModel):
 
 class RestCatalog(Catalog):
     uri: str
-    session: Session

Review Comment:
   Based on my understanding, these should not be class-level attributes.  Changes to one set of properties or session should not affect other catalog instances.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org