You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/09 15:22:29 UTC

[GitHub] [iotdb] MrQuansy commented on a diff in pull request #7792: [IOTDB-4784] Control total memory for enabling time partition for storage engine

MrQuansy commented on code in PR #7792:
URL: https://github.com/apache/iotdb/pull/7792#discussion_r1018079747


##########
server/src/test/java/org/apache/iotdb/db/engine/storagegroup/DataRegionTest.java:
##########
@@ -1111,7 +1111,7 @@ public void testDeleteDataInUnSeqFlushingMemtable()
     // delete data which is in work memtable
     dataRegion.deleteByDevice(new PartialPath("root.vehicle.d0.s0"), 50, 100, 0, null);
     dataRegion.deleteByDevice(new PartialPath("root.vehicle.d0.s0"), 50, 150, 0, null);
-    dataRegion.deleteByDevice(new PartialPath("root.vehicle.d0.s0"), 100, 300, 0, null);
+    dataRegion.deleteByDevice(new PartialPath("root.vehicle.d0.s0"), 100, 190, 0, null);

Review Comment:
   Before this pr, there is a bug about updating last flush time for a empty memtable. And if the bug has been fixed, this unit test needs to be corrected to prevent error...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org