You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/12/18 22:24:01 UTC
[jira] Created: (LUCENE-2821) FilterManager starts threads with no
way to stop, and should be in contrib/remote, not core
FilterManager starts threads with no way to stop, and should be in contrib/remote, not core
-------------------------------------------------------------------------------------------
Key: LUCENE-2821
URL: https://issues.apache.org/jira/browse/LUCENE-2821
Project: Lucene - Java
Issue Type: Bug
Reporter: Robert Muir
See the warning produced by contrib/remote's tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2821) FilterManager starts threads with
no way to stop, and should be in contrib/remote, not core
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977765#action_12977765 ]
Robert Muir commented on LUCENE-2821:
-------------------------------------
Since contrib/remote is now gone i want to:
* deprecate this functionality in 3.x, with the wordage "use your own LinkedHashmap", but apply this patch to clean it up.
* remove this class in trunk.
> FilterManager starts threads with no way to stop, and should be in contrib/remote, not core
> -------------------------------------------------------------------------------------------
>
> Key: LUCENE-2821
> URL: https://issues.apache.org/jira/browse/LUCENE-2821
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-2821.patch
>
>
> See the warning produced by contrib/remote's tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2821) FilterManager starts threads with
no way to stop, and should be in contrib/remote, not core
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988076#action_12988076 ]
Shai Erera commented on LUCENE-2821:
------------------------------------
Robert, are you sure we can apply the patch to 3x? I'm asking because it breaks back-compat. Few protected fields are removed and the Map's signature is changed from Map<Integer,FilterItem> to Map<Integer,Filter>. I doubt that anyone extends it, but perhaps someone's using it in a way that it will now break. Given that we deprecated it and removed in trunk, do you think it's worth the break?
> FilterManager starts threads with no way to stop, and should be in contrib/remote, not core
> -------------------------------------------------------------------------------------------
>
> Key: LUCENE-2821
> URL: https://issues.apache.org/jira/browse/LUCENE-2821
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-2821.patch
>
>
> See the warning produced by contrib/remote's tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Closed: (LUCENE-2821) FilterManager starts threads with no
way to stop, and should be in contrib/remote, not core
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir closed LUCENE-2821.
-------------------------------
Resolution: Duplicate
> FilterManager starts threads with no way to stop, and should be in contrib/remote, not core
> -------------------------------------------------------------------------------------------
>
> Key: LUCENE-2821
> URL: https://issues.apache.org/jira/browse/LUCENE-2821
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-2821.patch
>
>
> See the warning produced by contrib/remote's tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2821) FilterManager starts threads with no
way to stop, and should be in contrib/remote, not core
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2821:
--------------------------------
Attachment: LUCENE-2821.patch
here's a patch (apply after svn mv'ing this FilterManager to contrib/remote)
instead of a separate thread, uses LinkedHashMap to manage the cache (just like the TODO in the code alludes to)
All tests passed (only contrib/remote actually tested this functionality before anyway, even though it was in core)
> FilterManager starts threads with no way to stop, and should be in contrib/remote, not core
> -------------------------------------------------------------------------------------------
>
> Key: LUCENE-2821
> URL: https://issues.apache.org/jira/browse/LUCENE-2821
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-2821.patch
>
>
> See the warning produced by contrib/remote's tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org