You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/05 06:42:07 UTC

[GitHub] [incubator-apisix] Miss-you opened a new pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Miss-you opened a new pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658


   fix issue #1657 
   generate the 'worker_cpu_affinity' config
   
   NOTE: Please read the Contributing.md guidelines before submitting your patch:
   
   https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
   
   ### Summary
   
   SUMMARY_HERE
   
   ### Full changelog
   
   * [Implement ...]
   * [Add related tests]
   * ...
   
   ### Issues resolved
   
   Fix #XXX
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Miss-you commented on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
Miss-you commented on pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-640372304


   > @Miss-you please rebase your branch with `master`. This branch has conflicts that must be resolved.
   
   Okay, I'll resolve the conflict tonight.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Miss-you commented on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
Miss-you commented on pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-640173575


   @membphis 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-640330628


   @Miss-you please rebase your branch with `master`.  This branch has conflicts that must be resolved.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Miss-you edited a comment on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
Miss-you edited a comment on pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-640173575


   @membphis Please help with codereview.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#discussion_r437072525



##########
File path: bin/apisix
##########
@@ -21,6 +21,8 @@ local function trim(s)
     return (s:gsub("^%s*(.-)%s*$", "%1"))
 end
 
+-- Note: The `excute_cmd` return value will have a line break at the end,
+-- it is recommended to use the `trim` function to handle the return value.

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#discussion_r436434028



##########
File path: bin/apisix
##########
@@ -21,6 +21,8 @@ local function trim(s)
     return (s:gsub("^%s*(.-)%s*$", "%1"))
 end
 
+-- Note: The `excute_cmd` return value will have a line break at the end,
+-- it is recommended to use the `trim` function to handle the return value.

Review comment:
       we can move this comment to https://github.com/apache/incubator-apisix/pull/1658/files#diff-62edadffc237f13dc28a694080d293a8R670




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Miss-you commented on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
Miss-you commented on pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-641001189


   > > Okay, I'll resolve the conflict tonight.
   > 
   > I did it for you.
   
   thank you


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Miss-you commented on a change in pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
Miss-you commented on a change in pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#discussion_r436460305



##########
File path: bin/apisix
##########
@@ -21,6 +21,8 @@ local function trim(s)
     return (s:gsub("^%s*(.-)%s*$", "%1"))
 end
 
+-- Note: The `excute_cmd` return value will have a line break at the end,
+-- it is recommended to use the `trim` function to handle the return value.

Review comment:
       I think it's reasonable to put this function usage note in the corresponding function definition.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-640958806






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis merged pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org