You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/05/05 16:52:25 UTC

[GitHub] [orc] autumnust edited a comment on pull request #651: ORC-757: HashTable dictionary

autumnust edited a comment on pull request #651:
URL: https://github.com/apache/orc/pull/651#issuecomment-832850321


   > > > Updated the PR. @omalley @pgaref please take another look, thanks.
   > > 
   > > 
   > > Hey @autumnust thanks for the changes, latest PR looks pretty good -- JMH extension also helps a lot!
   > > Left some mostly minor comments, let me know what you think!
   > 
   > PR seems in pretty good shape already, @autumnust anything to polish/benchmark before going in? Whats the plan?
   
   @pgaref  thanks for getting back. I was trying to finalize the bucketSize thing and tune things a bit more. Will publish a new benchmark later today. Beyond this PR, I am planning to try the linear probing as the collision resolution method and do a benchmark with current impl. to see if there's any space for improvement. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org