[GitHub] [helix] kaisun2000 commented on a change in pull request #1000: Add message periodic refresh

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1000:
URL: https://github.com/apache/helix/pull/1000#discussion_r425314614



##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -714,7 +724,7 @@ private void syncSessionToController(HelixManager manager) {
 
   @Override
   @PreFetch(enabled = false)
-  public void onMessage(String instanceName, List<Message> messages,
+  public synchronized void onMessage(String instanceName, List<Message> messages,

Review comment:
       Previously only CallbacHandler (for message) would execute this onMessage() and it would be on ZkClient's event thread. 
   Now you have thread to execute this method. Make it would synchronized would be safe.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org