You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by staxmanade <gi...@git.apache.org> on 2014/07/06 01:45:27 UTC
[GitHub] cordova-windows pull request: use `-noprofile` when shelling out t...
GitHub user staxmanade opened a pull request:
https://github.com/apache/cordova-windows/pull/36
use `-noprofile` when shelling out to powershell
When shelling out to an external powershell commannd we probably want to not allow a user's `$PROFILE` to run as it could put us in an un-known directory (if our command depends on running from a specific directory).
```
powershell /help
...
-NoProfile
Does not load the Windows PowerShell profile.
...
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/staxmanade/cordova-windows patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit eaef0645dd6fe756abc254fd5cbfb0a5b1a4793c
Author: Jason Jarrett <ja...@elegantcode.com>
Date: 2014-07-05T23:45:10Z
use `-noprofile` when shelling out to powershell
When shelling out to an external powershell commannd we probably want to not allow a user's `$PROFILE` to run as it could put us in an un-known directory (if our command depends on running from a specific directory).
```
powershell /help
...
-NoProfile
Does not load the Windows PowerShell profile.
...
```
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: use `-noprofile` when shelling out t...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/36#issuecomment-48176344
LGTM, thx @staxmanade. We just need to update .jsproj to be consistent on how we run powershell.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: use `-noprofile` when shelling out t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: use `-noprofile` when shelling out t...
Posted by staxmanade <gi...@git.apache.org>.
Github user staxmanade commented on the pull request:
https://github.com/apache/cordova-windows/pull/36#issuecomment-48420076
Sorry all, I haven't had time to work on finishing this up. Maybe in a week or two.
FYI the change here fixed an issue I had locally which didn't allow whatever process I was doing to run correctly...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-windows pull request: use `-noprofile` when shelling out t...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/36#issuecomment-48417277
ping!
iCLA + Jira Issue + update .jsproj
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---