You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/30 21:01:28 UTC
Review Request 71207: Revert "Updated cpplint.py to be less verbose
when there is no linting issue."
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9360
https://issues.apache.org/jira/browse/MESOS-9360
Repository: mesos
Description
-------
This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.
This patch was necessary when we were running cpplint via
`support/mesos-style.py` to prevent it from cluttering up the hook
output. When running under pre-commit linter output is not shown if no
errors occur so we can undo our change to stay closer to upstream.
Diffs
-----
support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
Diff: https://reviews.apache.org/r/71207/diff/1/
Testing
-------
* used for development for a couple of months
* reports no issues in the current source tree
Thanks,
Benjamin Bannier
Re: Review Request 71207: Revert "Updated cpplint.py to be less
verbose when there is no linting issue."
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/#review217464
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 20, 2019, 4:49 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71207/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 4:49 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.
>
> This patch was necessary when we were running cpplint via
> `support/mesos-style.py` to prevent it from cluttering up the hook
> output. When running under pre-commit linter output is not shown if no
> errors occur so we can undo our change to stay closer to upstream.
>
>
> Diffs
> -----
>
> support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
>
>
> Diff: https://reviews.apache.org/r/71207/diff/3/
>
>
> Testing
> -------
>
> * used for development for a couple of months
> * reports no issues in the current source tree
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71207: Revert "Updated cpplint.py to be less
verbose when there is no linting issue."
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/#review217441
-----------------------------------------------------------
Ship it!
- Till Toenshoff
On Aug. 20, 2019, 11:49 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71207/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 11:49 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.
>
> This patch was necessary when we were running cpplint via
> `support/mesos-style.py` to prevent it from cluttering up the hook
> output. When running under pre-commit linter output is not shown if no
> errors occur so we can undo our change to stay closer to upstream.
>
>
> Diffs
> -----
>
> support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
>
>
> Diff: https://reviews.apache.org/r/71207/diff/3/
>
>
> Testing
> -------
>
> * used for development for a couple of months
> * reports no issues in the current source tree
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71207: Revert "Updated cpplint.py to be less
verbose when there is no linting issue."
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/
-----------------------------------------------------------
(Updated Aug. 20, 2019, 1:49 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Rebase
Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630
Repository: mesos
Description
-------
This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.
This patch was necessary when we were running cpplint via
`support/mesos-style.py` to prevent it from cluttering up the hook
output. When running under pre-commit linter output is not shown if no
errors occur so we can undo our change to stay closer to upstream.
Diffs (updated)
-----
support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
Diff: https://reviews.apache.org/r/71207/diff/3/
Changes: https://reviews.apache.org/r/71207/diff/2-3/
Testing
-------
* used for development for a couple of months
* reports no issues in the current source tree
Thanks,
Benjamin Bannier
Re: Review Request 71207: Revert "Updated cpplint.py to be less
verbose when there is no linting issue."
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/#review217285
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71207/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 9:01 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.
>
> This patch was necessary when we were running cpplint via
> `support/mesos-style.py` to prevent it from cluttering up the hook
> output. When running under pre-commit linter output is not shown if no
> errors occur so we can undo our change to stay closer to upstream.
>
>
> Diffs
> -----
>
> support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
>
>
> Diff: https://reviews.apache.org/r/71207/diff/2/
>
>
> Testing
> -------
>
> * used for development for a couple of months
> * reports no issues in the current source tree
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71207: Revert "Updated cpplint.py to be less
verbose when there is no linting issue."
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/#review217268
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71207/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 9:01 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.
>
> This patch was necessary when we were running cpplint via
> `support/mesos-style.py` to prevent it from cluttering up the hook
> output. When running under pre-commit linter output is not shown if no
> errors occur so we can undo our change to stay closer to upstream.
>
>
> Diffs
> -----
>
> support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
>
>
> Diff: https://reviews.apache.org/r/71207/diff/2/
>
>
> Testing
> -------
>
> * used for development for a couple of months
> * reports no issues in the current source tree
>
>
> Thanks,
>
> Benjamin Bannier
>
>