You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2013/10/22 20:56:48 UTC
Review Request 14849: ACCUMULO-1584 ACCUMULO_CONF_DIR not respected for
accumulo-metrics.xml
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14849/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-1584
https://issues.apache.org/jira/browse/ACCUMULO-1584
Repository: accumulo
Description
-------
Changes MetricsConfiguration to respect the ACCUMULO_CONF_DIR rather than hard code conf/
Diffs
-----
src/server/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java 6c6400f
Diff: https://reviews.apache.org/r/14849/diff/
Testing
-------
we've been running functional and integration tests with this patch in place on 1.4.x for some time.
Thanks,
Sean Busbey
Re: Review Request 14849: ACCUMULO-1584 ACCUMULO_CONF_DIR not respected for
accumulo-metrics.xml
Posted by Sean Busbey <se...@manvsbeard.com>.
> On Oct. 22, 2013, 6:59 p.m., Sean Busbey wrote:
> > Ship It!
non-binding. Also, note that Jon Hsieh is the original author, not me.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14849/#review27325
-----------------------------------------------------------
On Oct. 22, 2013, 6:56 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14849/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 6:56 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1584
> https://issues.apache.org/jira/browse/ACCUMULO-1584
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Changes MetricsConfiguration to respect the ACCUMULO_CONF_DIR rather than hard code conf/
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java 6c6400f
>
> Diff: https://reviews.apache.org/r/14849/diff/
>
>
> Testing
> -------
>
> we've been running functional and integration tests with this patch in place on 1.4.x for some time.
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 14849: ACCUMULO-1584 ACCUMULO_CONF_DIR not respected for
accumulo-metrics.xml
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14849/#review27325
-----------------------------------------------------------
Ship it!
Ship It!
- Sean Busbey
On Oct. 22, 2013, 6:56 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14849/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 6:56 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1584
> https://issues.apache.org/jira/browse/ACCUMULO-1584
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Changes MetricsConfiguration to respect the ACCUMULO_CONF_DIR rather than hard code conf/
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java 6c6400f
>
> Diff: https://reviews.apache.org/r/14849/diff/
>
>
> Testing
> -------
>
> we've been running functional and integration tests with this patch in place on 1.4.x for some time.
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 14849: ACCUMULO-1584 ACCUMULO_CONF_DIR not respected for
accumulo-metrics.xml
Posted by Bill Havanki <bh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14849/#review27329
-----------------------------------------------------------
Ship it!
I've been running tests with this change in place without incident.
- Bill Havanki
On Oct. 22, 2013, 2:56 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14849/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 2:56 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1584
> https://issues.apache.org/jira/browse/ACCUMULO-1584
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Changes MetricsConfiguration to respect the ACCUMULO_CONF_DIR rather than hard code conf/
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java 6c6400f
>
> Diff: https://reviews.apache.org/r/14849/diff/
>
>
> Testing
> -------
>
> we've been running functional and integration tests with this patch in place on 1.4.x for some time.
>
>
> Thanks,
>
> Sean Busbey
>
>