You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/06/06 12:39:26 UTC

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #839: IGNITE-14209 Data rebalance on partition replicas' number changes

sanpwc commented on code in PR #839:
URL: https://github.com/apache/ignite-3/pull/839#discussion_r890106796


##########
modules/core/src/main/java/org/apache/ignite/internal/causality/VersionedValue.java:
##########
@@ -594,7 +594,7 @@ private void trimToSize(long causalityToken) {
      * @param causalityToken Causality token.
      */
     private static void checkToken(long actualToken, long causalityToken) {

Review Comment:
   Not related to proposed changes but...
   Both actualToken and causalityToken are causality tokens, I'd rather use "appliedToken" and "candidateToken" or similar. If you don't mind, lets fix it here. Besides that checkToken is rather assertToken, up to you though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org