You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/15 00:58:07 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #8049:
fix: onSave datasource raises React error
mistercrunch opened a new pull request #8049: fix: onSave datasource raises React error
URL: https://github.com/apache/incubator-superset/pull/8049
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
When saving a datasource in the explore view, React throws up
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="651" alt="Screen Shot 2019-08-14 at 2 36 23 PM" src="https://user-images.githubusercontent.com/487433/63065975-fa101d80-bebc-11e9-86cd-4cfae4a58a45.png">
### TEST PLAN
Wrote a unit test to make sure React doesn't fail when props are null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org