You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "betodealmeida (GitHub)" <gi...@apache.org> on 2018/08/24 01:30:22 UTC

[GitHub] [incubator-superset] betodealmeida opened pull request #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

In some of our charts `fd.timeseries_limit_metric` is being initialized to an empty array instead of `null`. This results in `sortBy` being set to an empty array, and then the last metric column is hidden.

[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=h1) Report
> Merging [#5715](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e6efae15563036d98aa9a13affcef38c6957cb1?src=pr&el=desc) will **increase** coverage by `0.35%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5715/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5715      +/-   ##
==========================================
+ Coverage   63.43%   63.78%   +0.35%     
==========================================
  Files         361      362       +1     
  Lines       22977    22983       +6     
  Branches     2558     2557       -1     
==========================================
+ Hits        14575    14660      +85     
+ Misses       8387     8308      -79     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/table.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90YWJsZS5qcw==) | `82.75% <100%> (+82.75%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.14% <0%> (-2.01%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.86% <0%> (-0.77%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.6% <0%> (-0.5%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.64% <0%> (-0.3%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | `22.92% <0%> (-0.12%)` | :arrow_down: |
| [...uperset/assets/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXRhc291cmNlL0RhdGFzb3VyY2VFZGl0b3IuanN4) | `72.92% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `46.26% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/sunburst.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9zdW5idXJzdC5qcw==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/treemap.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90cmVlbWFwLmpz) | `0% <0%> (ø)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=footer). Last update [5e6efae...cd2d224](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=h1) Report
> Merging [#5715](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e6efae15563036d98aa9a13affcef38c6957cb1?src=pr&el=desc) will **increase** coverage by `0.35%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5715/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5715      +/-   ##
==========================================
+ Coverage   63.43%   63.78%   +0.35%     
==========================================
  Files         361      362       +1     
  Lines       22977    22983       +6     
  Branches     2558     2557       -1     
==========================================
+ Hits        14575    14660      +85     
+ Misses       8387     8308      -79     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/table.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90YWJsZS5qcw==) | `82.75% <100%> (+82.75%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.14% <0%> (-2.01%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.86% <0%> (-0.77%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.6% <0%> (-0.5%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.64% <0%> (-0.3%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | `22.92% <0%> (-0.12%)` | :arrow_down: |
| [...uperset/assets/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXRhc291cmNlL0RhdGFzb3VyY2VFZGl0b3IuanN4) | `72.92% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `46.26% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/sunburst.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9zdW5idXJzdC5qcw==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/treemap.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90cmVlbWFwLmpz) | `0% <0%> (ø)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=footer). Last update [5e6efae...cd2d224](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] betodealmeida commented on pull request #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "betodealmeida (GitHub)" <gi...@apache.org>.
Technically no, if the array has no elements then `limitMetric` is `undefined`, which is false and does the expected in line 191.

[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=h1) Report
> Merging [#5715](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e6efae15563036d98aa9a13affcef38c6957cb1?src=pr&el=desc) will **increase** coverage by `0.35%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5715/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5715      +/-   ##
==========================================
+ Coverage   63.43%   63.78%   +0.35%     
==========================================
  Files         361      362       +1     
  Lines       22977    22983       +6     
  Branches     2558     2557       -1     
==========================================
+ Hits        14575    14660      +85     
+ Misses       8387     8308      -79     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/table.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90YWJsZS5qcw==) | `82.75% <100%> (+82.75%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.14% <0%> (-2.01%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.86% <0%> (-0.77%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.6% <0%> (-0.5%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.64% <0%> (-0.3%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | `22.92% <0%> (-0.12%)` | :arrow_down: |
| [...uperset/assets/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXRhc291cmNlL0RhdGFzb3VyY2VFZGl0b3IuanN4) | `72.92% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `46.26% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/sunburst.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9zdW5idXJzdC5qcw==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/treemap.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90cmVlbWFwLmpz) | `0% <0%> (ø)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=footer). Last update [5e6efae...cd2d224](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
No need to check on `.length`?

[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
Unrelated to this PR: It's driving me crazy the number of places in the code where we deal with the historical metrics! We'll need to clean that up some day. Maybe that can be an early place where we enforce a typescript schema, and do it way upstream.

[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=h1) Report
> Merging [#5715](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e6efae15563036d98aa9a13affcef38c6957cb1?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5715/graphs/tree.svg?token=KsB0fHcx6l&width=650&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5715      +/-   ##
==========================================
- Coverage   63.43%   63.42%   -0.01%     
==========================================
  Files         361      361              
  Lines       22977    22980       +3     
  Branches     2558     2560       +2     
==========================================
  Hits        14575    14575              
- Misses       8387     8390       +3     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/table.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90YWJsZS5qcw==) | `0% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=footer). Last update [5e6efae...949dab3](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=h1) Report
> Merging [#5715](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e6efae15563036d98aa9a13affcef38c6957cb1?src=pr&el=desc) will **increase** coverage by `0.35%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5715/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5715      +/-   ##
==========================================
+ Coverage   63.43%   63.78%   +0.35%     
==========================================
  Files         361      362       +1     
  Lines       22977    22983       +6     
  Branches     2558     2557       -1     
==========================================
+ Hits        14575    14660      +85     
+ Misses       8387     8308      -79     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/table.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90YWJsZS5qcw==) | `82.75% <100%> (+82.75%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.14% <0%> (-2.01%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.86% <0%> (-0.77%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.6% <0%> (-0.5%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.64% <0%> (-0.3%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | `22.92% <0%> (-0.12%)` | :arrow_down: |
| [...uperset/assets/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXRhc291cmNlL0RhdGFzb3VyY2VFZGl0b3IuanN4) | `72.92% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `46.26% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/sunburst.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9zdW5idXJzdC5qcw==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/treemap.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90cmVlbWFwLmpz) | `0% <0%> (ø)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=footer). Last update [5e6efae...cd2d224](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch commented on issue #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
LGTM

[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] betodealmeida closed pull request #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "betodealmeida (GitHub)" <gi...@apache.org>.
[ pull request closed by betodealmeida ]

[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=h1) Report
> Merging [#5715](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e6efae15563036d98aa9a13affcef38c6957cb1?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5715/graphs/tree.svg?height=150&width=650&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5715      +/-   ##
==========================================
- Coverage   63.43%   63.42%   -0.01%     
==========================================
  Files         361      361              
  Lines       22977    22980       +3     
  Branches     2558     2560       +2     
==========================================
  Hits        14575    14575              
- Misses       8387     8390       +3     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/table.js](https://codecov.io/gh/apache/incubator-superset/pull/5715/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90YWJsZS5qcw==) | `0% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=footer). Last update [5e6efae...949dab3](https://codecov.io/gh/apache/incubator-superset/pull/5715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5715 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org