You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2020/04/20 20:34:25 UTC
[wicket] branch wicket-8.x updated: WICKET-6767 Do not log error
for broken pipes in websocket connections
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch wicket-8.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/wicket-8.x by this push:
new 6c8a834 WICKET-6767 Do not log error for broken pipes in websocket connections
6c8a834 is described below
commit 6c8a8341bf04f5c5e579697cabc2eb8590cf337f
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
AuthorDate: Mon Apr 20 23:32:59 2020 +0300
WICKET-6767 Do not log error for broken pipes in websocket connections
(cherry picked from commit 096eccb400304a11ec13a47b436c1fdb7dad49a0)
---
.../org/apache/wicket/protocol/ws/javax/WicketEndpoint.java | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketEndpoint.java b/wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketEndpoint.java
index 829fe90..dcacd6b 100644
--- a/wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketEndpoint.java
+++ b/wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketEndpoint.java
@@ -17,6 +17,7 @@
package org.apache.wicket.protocol.ws.javax;
import java.io.EOFException;
+import java.io.IOException;
import java.util.List;
import java.util.Map;
import java.util.concurrent.atomic.AtomicBoolean;
@@ -90,7 +91,7 @@ public class WicketEndpoint extends Endpoint
@Override
public void onError(Session session, Throwable t)
{
- if (t instanceof EOFException)
+ if (isIgnorableError(t))
{
LOG.debug("An error occurred in web socket connection with id : {}", session.getId(), t);
}
@@ -107,6 +108,13 @@ public class WicketEndpoint extends Endpoint
}
}
+ private boolean isIgnorableError(Throwable t)
+ {
+ return
+ t instanceof EOFException ||
+ (t instanceof IOException && "Broken pipe".equals(t.getMessage()));
+ }
+
private boolean isApplicationAlive() {
return applicationDestroyed.get() == false;
}