Re: [PR] fix: cancel active `/workOrder` futures on query cancellation (druid)

["Fly-Style (via GitHub)" <gi...@apache.org>]

Fly-Style commented on code in PR #20313:
URL: https://github.com/apache/druid/pull/20313#discussion_r3988823379


##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/worker/DartWorkerClientImpl.java:
##########
@@ -140,8 +147,26 @@ public void close()
   }
 
   @Override
-  public ListenableFuture<?> stopWorker(String workerId)
+  public ListenableFuture<Void> postWorkOrder(final String workerId, final WorkOrder workOrder)
+  {
+    final ListenableFuture<Void> future = super.postWorkOrder(workerId, workOrder);

Review Comment:
   Fixed in 9b7eafa



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org