You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/07/23 15:15:58 UTC
[GitHub] [kylin] hit-lacus opened a new pull request #1327: KYLIN-4660 Remove some module from maven project
hit-lacus opened a new pull request #1327:
URL: https://github.com/apache/kylin/pull/1327
Some feature is plan to be removed in Kylin 4.X, let us keep the source code and remove them from maven.
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus edited a comment on pull request #1327: KYLIN-4660 Remove some module from maven project
Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on pull request #1327:
URL: https://github.com/apache/kylin/pull/1327#issuecomment-664062646
Travis-CI failed because log size exceed limit. We should open another ticket to fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1327: KYLIN-4660 Remove some module from maven project
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1327:
URL: https://github.com/apache/kylin/pull/1327#issuecomment-664060095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1327: KYLIN-4660 Remove some module from maven project
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1327:
URL: https://github.com/apache/kylin/pull/1327#issuecomment-664062646
Travis-CI failed because log size exceed limit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus edited a comment on pull request #1327: KYLIN-4660 Remove some module from maven project
Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on pull request #1327:
URL: https://github.com/apache/kylin/pull/1327#issuecomment-664062646
Travis-CI failed because log size exceed limit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1327: KYLIN-4660 Remove some module from maven project
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1327:
URL: https://github.com/apache/kylin/pull/1327#issuecomment-664064157
This pull request **fixes 38 alerts** when merging 9ff4b7eca700ead4d76fac50a364d114df9b2137 into 95b1af050a708dbd16710e530a8df10335eb09fd - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-079b44d1d9ec6604495b8fd708ab1f7b86a9ff95)
**fixed alerts:**
* 8 for Dereferenced variable may be null
* 6 for Boxed variable is never null
* 5 for Implicit narrowing conversion in compound assignment
* 4 for Useless null check
* 3 for Useless comparison test
* 2 for Implicit conversion from array to string
* 2 for Spurious Javadoc @param tags
* 2 for Unused format argument
* 2 for Potential input resource leak
* 1 for Result of multiplication cast to wider type
* 1 for Potential database resource leak
* 1 for Potential output resource leak
* 1 for Iterable wrapping an iterator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1327: KYLIN-4660 Remove some module from maven project
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1327:
URL: https://github.com/apache/kylin/pull/1327#issuecomment-664108015
This pull request **fixes 38 alerts** when merging 97db36c0fc8480b1dbb89bf34eab845e95dc739f into 95b1af050a708dbd16710e530a8df10335eb09fd - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-c14a55c9e0bf742561fcca4f6996263e863d88ff)
**fixed alerts:**
* 8 for Dereferenced variable may be null
* 6 for Boxed variable is never null
* 5 for Implicit narrowing conversion in compound assignment
* 4 for Useless null check
* 3 for Useless comparison test
* 2 for Implicit conversion from array to string
* 2 for Spurious Javadoc @param tags
* 2 for Unused format argument
* 2 for Potential input resource leak
* 1 for Result of multiplication cast to wider type
* 1 for Potential database resource leak
* 1 for Potential output resource leak
* 1 for Iterable wrapping an iterator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1327: KYLIN-4660 Remove some module from maven project
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1327:
URL: https://github.com/apache/kylin/pull/1327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org