You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/22 12:32:22 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6235: NIFI-10265 Route to Failure on Connect Exceptions in PutDatabaseRecord

exceptionfactory opened a new pull request, #6235:
URL: https://github.com/apache/nifi/pull/6235

   # Summary
   
   [NIFI-10265](https://issues.apache.org/jira/browse/NIFI-10265) Updates `PutDatabaseRecord` to route FlowFiles to the `failure` relationship when failing to retrieve a JDBC Connection from the Database Connection Pool Service.
   
   The current behavior calls `DBCPService.getConnection()` outside of the general try-catch block. As a result of this approach, any exceptions thrown from `getConnection()` cause incoming FlowFiles to remain in the queue, instead of being processed. The adjustment moves `getConnection()` inside the try-catch block so that exceptions, such as network connection failures, will cause FlowFiles to be routed to the `failure` relationship.
   
   Additional changes include adding a unit test for the condition and updating the unit test class to JUnit 5.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #6235: NIFI-10265 Route to Failure on Connect Exceptions in PutDatabaseRecord

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6235:
URL: https://github.com/apache/nifi/pull/6235#issuecomment-1194060738

   +1 LGTM, verified the expected behavior with Rollback On Failure set to false then true. Thanks for the fix! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #6235: NIFI-10265 Route to Failure on Connect Exceptions in PutDatabaseRecord

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6235:
URL: https://github.com/apache/nifi/pull/6235#issuecomment-1194009270

   Reviewing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 closed pull request #6235: NIFI-10265 Route to Failure on Connect Exceptions in PutDatabaseRecord

Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6235: NIFI-10265 Route to Failure on Connect Exceptions in PutDatabaseRecord
URL: https://github.com/apache/nifi/pull/6235


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org