You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2010/11/11 10:23:13 UTC
[jira] Created: (HAMA-331) Implementation of JobInProgressListener
Implementation of JobInProgressListener
---------------------------------------
Key: HAMA-331
URL: https://issues.apache.org/jira/browse/HAMA-331
Project: Hama
Issue Type: Improvement
Components: bsp
Affects Versions: 0.2.0
Reporter: Edward J. Yoon
Fix For: 0.2.0
I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-331) Implementation of
JobInProgressListener
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966287#action_12966287 ]
Filipe Manana commented on HAMA-331:
------------------------------------
Edward,
shouldn't BSPMaster.JobInitThread.shouldRun be volatile?
cheers
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch, HAMA-331_v02.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-331) Implementation of
JobInProgressListener
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966036#action_12966036 ]
Hudson commented on HAMA-331:
-----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12465116/HAMA-331_v02.patch
against trunk revision 1039006.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/297/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/297/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/297/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/297/console
This message is automatically generated.
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch, HAMA-331_v02.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-331) Implementation of JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-331:
--------------------------------
Status: Open (was: Patch Available)
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch, HAMA-331_v02.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-331) Implementation of
JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966404#action_12966404 ]
Edward J. Yoon commented on HAMA-331:
-------------------------------------
Oh, sorry. you're right. It should be a volatile. Later, it can be accessed by other threads.
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch, HAMA-331_v02.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-331) Implementation of JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-331:
--------------------------------
Status: Patch Available (was: Open)
Running patch though hudson
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HAMA-331) Implementation of JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HAMA-331:
-----------------------------------
Assignee: Edward J. Yoon
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-331) Implementation of
JobInProgressListener
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966024#action_12966024 ]
Hudson commented on HAMA-331:
-----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12465114/clear.patch
against trunk revision 1039006.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs -1. The patch appears to introduce 4 new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/296/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/296/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/296/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/296/console
This message is automatically generated.
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-331) Implementation of JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-331:
--------------------------------
Status: Patch Available (was: Open)
Rescheduling~
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch, HAMA-331_v02.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-331) Implementation of JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-331:
--------------------------------
Attachment: clear.patch
Simply, I just removed un-implemented codes. And this patch also includes a little implementations of kill-job method.
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-331) Implementation of JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-331:
--------------------------------
Attachment: HAMA-331_v02.patch
The kill() and assignTask() should be a synchronized method, and I replaced thread starter to offerService() from BSPMaster constructor.
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch, HAMA-331_v02.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-331) Implementation of
JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966389#action_12966389 ]
Edward J. Yoon commented on HAMA-331:
-------------------------------------
Well, that variable is only used in JobInitThread thread. I think we don't need to change the keyword of that variable.
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch, HAMA-331_v02.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-331) Implementation of
JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966020#action_12966020 ]
Edward J. Yoon commented on HAMA-331:
-------------------------------------
I'm submit this patch.
I tried to use the JobInProgressListener, but it related with the job scheduler and FT mechanisms. It will unnecessarily cause complexity and difficulty in source code. So, I want to remove them.
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-331) Implementation of JobInProgressListener
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-331:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just committed this.
> Implementation of JobInProgressListener
> ---------------------------------------
>
> Key: HAMA-331
> URL: https://issues.apache.org/jira/browse/HAMA-331
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.2.0
>
> Attachments: clear.patch, HAMA-331_v02.patch
>
>
> I didn't recognized but, it should be implemented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.