You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by wuchong <gi...@git.apache.org> on 2016/09/09 06:07:58 UTC
[GitHub] flink pull request #2482: [FLINK-4579] [StateBackend] Add StateBackendFactor...
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2482
[FLINK-4579] [StateBackend] Add StateBackendFactory for RocksDB Backend
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR also add the rocksdb backend to the standard distribution lib to avoid manually place rocksdb jars to the Flink lib folder.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink FLINK-4579-rocksdb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2482.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2482
----
commit 57ddd27524b127a0bbfe461846a6ac8f4e590b5b
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2016-09-09T05:38:26Z
[FLINK-4579] [StateBackend] Add StateBackendFactory for RocksDB Backend
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2482
Good point. I think reflect is good, if it does not add too much work. Keeping the modules separate is nice, I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2482
Looks good, thanks!
Rebasing and merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2482
Added a shortcut (rocksdb) for configuring RocksDB state backend and added the dedicated option config `state.backend.rocksdb.checkpointdir`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2482
Looks good. I think we could even go one step further and have a shortcut (`rocksdb`) similar to `filesystem` and `jobmanager`.
We should then also have dedicated options, like `state.backend.rocksdb.checkpointdir`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2482
Hi @StephanEwen , if we want to have a shortcut (`rocksdb`), what should we do? Add the rocksdb dependency into `flink-streaming-java` module ? Or use java reflect ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2482: [FLINK-4579] [StateBackend] Add StateBackendFactor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---