You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/01/25 15:30:36 UTC

[GitHub] [flink] XComp opened a new pull request, #21757: [FLINK-30788][runtime] Refactors AbstractHaServices.createLeaderElectionService to return LeaderElectionDriverFactory

XComp opened a new pull request, #21757:
URL: https://github.com/apache/flink/pull/21757

   ## What is the purpose of the change
   
   The HA-backend-specific code is actually only the `LeaderElectionDriverFactory` creation rather than instantiating the `LeaderElectionService`. This is meant as a prep PR to reduce the code diff of the actual FLINK-26522 changes.
   
   ## Brief change log
   
   * Introduces abstract method `createLeaderElectionDriverFactory(String)` that's called by `createLeaderElectionService(String)` 
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21757: [FLINK-30788][runtime] Refactors AbstractHaServices.createLeaderElectionService to return LeaderElectionDriverFactory

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #21757:
URL: https://github.com/apache/flink/pull/21757#issuecomment-1413624793

   > There's an HA e2e test failing.
   
   I created FLINK-30883 to cover this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21757: [FLINK-30788][runtime] Refactors AbstractHaServices.createLeaderElectionService to return LeaderElectionDriverFactory

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #21757:
URL: https://github.com/apache/flink/pull/21757#issuecomment-1403813850

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b8076300bc534464a6501ac255f1659b06162ab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8b8076300bc534464a6501ac255f1659b06162ab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b8076300bc534464a6501ac255f1659b06162ab UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21757: [FLINK-30788][runtime] Refactors AbstractHaServices.createLeaderElectionService to return LeaderElectionDriverFactory

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #21757:
URL: https://github.com/apache/flink/pull/21757#issuecomment-1415845019

   Rebase to most-recent `master`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #21757: [FLINK-30788][runtime] Refactors AbstractHaServices.createLeaderElectionService to return LeaderElectionDriverFactory

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #21757:
URL: https://github.com/apache/flink/pull/21757


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21757: [FLINK-30788][runtime] Refactors AbstractHaServices.createLeaderElectionService to return LeaderElectionDriverFactory

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #21757:
URL: https://github.com/apache/flink/pull/21757#issuecomment-1410643583

   ...just rebased to most-recent `master`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #21757: [FLINK-30788][runtime] Refactors AbstractHaServices.createLeaderElectionService to return LeaderElectionDriverFactory

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #21757:
URL: https://github.com/apache/flink/pull/21757#issuecomment-1412380685

   @flinkbot run azure
   
   There's an HA e2e test failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org