[GitHub] [maven-assembly-plugin] michael-o commented on a diff in pull request #134: [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver

["michael-o (via GitHub)" <gi...@apache.org>]

michael-o commented on code in PR #134:
URL: https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174595582


##########
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##########
@@ -293,10 +294,7 @@ protected Archiver createArchiver(
         final List<FileSelector> extraSelectors = new ArrayList<>();
         final List<ArchiveFinalizer> extraFinalizers = new ArrayList<>();
         if (archiver instanceof JarArchiver) {
-            if (mergeManifestMode != null) {
-                ((JarArchiver) archiver)
-                        .setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
-            }
+            configureJarArchiver((JarArchiver) archiver, mergeManifestMode, configSource.getJarArchiveConfiguration());

Review Comment:
   I would expect that this applies to all JAR derived formats? WAR, EAR, CAR, etc?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org