You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/23 13:04:28 UTC

[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #3462: ARTEMIS-3133 Reduce memory usage for Null an Ping packets

michaelpearce-gain commented on a change in pull request #3462:
URL: https://github.com/apache/activemq-artemis/pull/3462#discussion_r581017444



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java
##########
@@ -921,7 +979,11 @@ private void doConfirmAndResponse(final Packet confirmPacket,
       }
 
       if (response != null) {
-         channel.send(response);
+         try {
+            channel.send(response);

Review comment:
       is this blocking or async, i ask, because if its async you need to be careful, putting back the object into the pool, as it may not be finished with.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org