You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/05/11 06:26:43 UTC

[GitHub] activemq-artemis pull request #2082: ARTEMIS-1783 Remove need for guava in c...

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2082

    ARTEMIS-1783 Remove need for guava in client

    Refactor away from Guava memorize based on Guava Supplier to using java.util.Supplier and our own memorizer code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1783

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2082.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2082
    
----
commit 8bfa6cfada8f35be92774c6ae6e9c39531122448
Author: Michael André Pearce <mi...@...>
Date:   2018-05-11T06:24:35Z

    ARTEMIS-1783 Remove need for guava in client
    
    Refactor away from Guava memorize based on Guava Supplier to using java.util.Supplier and our own memorizer code.

----


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    So guava was added client side only due to this change right. I think server side has had guava for a time. Concern I think is more about client dependencies not so much server side right?


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    @michaelandrepearce nice one... we only need guava now for the CLI.. but that won't affect any runtime.. which is great!
    
    



---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    @franz1981 thanks for checking, will wait for @clebertsuconic and @jbertram to review also before we merge.


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by jbertram <gi...@git.apache.org>.

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    I like it better than my solution. +1


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    @clebertsuconic removed guava entirely, and replaced either with Java Function equivalents (majority) or added a few extra bits in Artemis utils.


---

[GitHub] activemq-artemis pull request #2082: ARTEMIS-1783 Remove need for guava in c...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2082


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    @michaelandrepearce We will have guava on artemis.commons... we would need to find a solution for those collections as well.


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by franz1981 <gi...@git.apache.org>.

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    @michaelandrepearce It looks fine to me: i haven't considered the client side deps on the past PR, sorry!


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    or just live with guava.


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    @clebertsuconic @jbertram alternative to https://github.com/apache/activemq-artemis/pull/2081 so we don't have to increase client side dependencies.


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    @clebertsuconic where is it in the CLI, i must have not noticed, if you can point me to it,  ill try see what we can do there.


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    Just looking to remove it from collections also and ip6 checks. That way we can fully remove


---

[GitHub] activemq-artemis issue #2082: ARTEMIS-1783 Remove need for guava in client

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2082
  
    @michaelandrepearce io.airlift itself is using it.
    
    I don't consider a big deal. this is not leaking to the server.


---