You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Victor J. Orlikowski" <v....@gte.net> on 2000/09/05 19:46:37 UTC

[PATCH] Not quite innocuous typo

Hmm, this could pose a slight problem....
Checking the pointer, rather than what it's pointing to for length.

Index: src/ap/ap_buckets_pipe.c
===================================================================
RCS file: /cvs/apache/apache-2.0/src/ap/ap_buckets_pipe.c,v
retrieving revision 1.5
diff -u -r1.5 ap_buckets_pipe.c
--- ap_buckets_pipe.c   2000/09/04 05:42:20     1.5
+++ ap_buckets_pipe.c   2000/09/05 17:48:15
@@ -85,7 +85,7 @@
        free(buf);
         return rv;
     }
-    if (len > 0) {
+    if (*len > 0) {
         a = ap_bucket_create_pipe(bd->thepipe);
         b = ap_bucket_make_heap(b, buf, *len, 0, NULL);

Victor
-- 
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
vjo@raleigh.ibm.com
vjo@us.ibm.com

Re: [PATCH] Not quite innocuous typo

Posted by Tony Finch <do...@dotat.at>.
"Victor J. Orlikowski" <v....@gte.net> wrote:
>Hmm, this could pose a slight problem....
>Checking the pointer, rather than what it's pointing to for length.

oops, yes, and thanks to Jeff for committing the fix.

Tony.
-- 
en oeccget g mtcaa    f.a.n.finch
v spdlkishrhtewe y    dot@dotat.at
eatp o v eiti i d.    fanf@covalent.net