[jira] [Commented] (ZOOKEEPER-2620) Add comments to testReadOnlySnapshotDir and testReadOnlyTxnLogDir indicating that the tests will fail when run as root

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603400#comment-15603400 ] 

Hadoop QA commented on ZOOKEEPER-2620:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12835019/ZOOKEEPER-2620.patch-br3.4
  against trunk revision cef5978969bedfe066f903834a9ea4af6d508844.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3498//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3498//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3498//console

This message is automatically generated.

> Add comments to testReadOnlySnapshotDir and testReadOnlyTxnLogDir indicating that the tests will fail when run as root
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2620
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2620
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>         Attachments: ZOOKEEPER-2620.patch, ZOOKEEPER-2620.patch-br3.4
>
>
> testReadOnlySnapshotDir and testReadOnlyTxnLogDir test the impact of changes to file system permissions on ZooKeeper server startup. 
> After debugging test failures [~hanm] was experiencing, we noticed that when the unit tests are run as root, these tests fail. We should have a comment to clarify this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)